clean up Twitter integration

[chadwhitacre]

The two main tickets so far for this are #289 and #313. I'm starting a new ticket here so that I can talk to myself without interrupting all the watchers on those tickets. :-)

[chadwhitacre]

This is about the interaction of participants with social_network_users.

[chadwhitacre]

Participants can be claimed or unclaimed.

Unclaimed participants are 1:1 with a social_network_user.

Claimed participants are 1:N with social_network_users.

[chadwhitacre]

I think it might be time to implement a bit of an object model for participants. I started this at one point but then backed it out and I can't remember why. :-(

Currently we interact with participants mostly through functions in gittip/init.py. I'm considering defining Participant and SocialNetworkAccount classes. All of the get_ functions from gittip/init.py would go on Participant.

participant = Participant('whit537')
tip = participant.get_tip_to('dowski')
# etc.

github_account = GitHubAccount('whit537')
twitter_account = TwitterAccount('whit537')

participant.connect_account(github_account)
participant.connect_account(twitter_account)

[chadwhitacre]

I need to make sure b340cf8 works for authenticated users (ideally with some more tests in test_pages.py) and then I'll release this so far.

[chadwhitacre]

Okay, work so far is deployed as 5.4.28.

[chadwhitacre]

Next steps:

• Implement SocialNetworkUser class (includes subclasses for each network, and using these in existing simplates where appropriate).
• Implement connect_account method on Participant object. That will do the heavy lifting of merging accounts as needed and will be where we have to tease that out fully.
• Add UI for firing connect_account -- probably needs confirmation dialogs for merging accounts?

[chadwhitacre]

How will participant absorption affect nparticipants during payday?

[chadwhitacre]

Deployed work to date as 5.4.33.

[chadwhitacre]

Deployed as 5.5.3.

[chadwhitacre]

I'm refactoring the login machinery.

[chadwhitacre]

Punchlist for UI:

• compute folded dollars accurately—we do sum tips to/from others, so that's handled already; it's tips to/from self/other we have to watch out for—reticketed as compute folded dollars accurately on merge UI #423
• implement all obstacle cases
• test all cases (eep!) :-(
• handle long usernames more elegantly—reticketed as handle long usernames more elegantly in merge account UI #424
• make sure only authorized users can take_over

[chadwhitacre]

General punchlist:

• shouldn't we invalidate balanced accounts when we archive old Gittip accounts?—reticketed as invalidate in Balanced for archived Gittip accounts #425
• there's no way in the UI to replace an account at the moment; "disconnect account" would address this—reticketed as add UI for removing and/or reconnecting an account #422
• probably want both "disconnect" and "replace with" (or some such)—reticketed as add UI for removing and/or reconnecting an account #422
• should probably end the login session for an archived Gittip account
• sure some refactoring to do <:-) :-(
• probably want to record reconnects even they're not absorptions - happens already (see post-connect lands on 404 #421, e.g.)

[chadwhitacre]

Deployed as 5.5.7.