Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

get version out of gittip/__init__.py #410

Closed
chadwhitacre opened this issue Dec 6, 2012 · 6 comments
Closed

get version out of gittip/__init__.py #410

chadwhitacre opened this issue Dec 6, 2012 · 6 comments

Comments

@chadwhitacre
Copy link
Contributor

Put it in a txt file where it's less likely to screw stuff up (cf. #405 and 9168a2e and 4155a03)

@chadwhitacre
Copy link
Contributor Author

The way this failed is that I had local changes to __init__.py and the release script pushed those to production even though I had been careful not to add them myself. Those changes were part of other unfinished work on #405 and #406 and so they weren't ready for production yet.

@mahmoudimus
Copy link

@whit537, we use a very good pattern for __version__, let me see if I can whip up a snippet.

@chadwhitacre
Copy link
Contributor Author

Thanks @mahmoudimus. I ended up going with a text file pattern that I've used elsewhere. Version now available at:

https://www.gittip.com/version.txt

and much less likely to cause problems as above.

@sigmavirus24
Copy link
Contributor

@mahmoudimus I'd still be interested in your snippet ;)

@mahmoudimus
Copy link

@sigmavirus24 OK :) I'll get it out soon since there's no rush

@sigmavirus24
Copy link
Contributor

Take your time. I'm in no rush either.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants