This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Switch to new environment.py library for config #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I factored out a new library called environment.py to manage configuration from environment variables. This commit replaces our former usage of the envvar function with environment. The next step is ot replace all of our direct os.environ access.
|
I started in on this when @rummik and I were talking about js testing and DevNet (old ticket is #615, not sure we have a new one yet). The thought is to have an |
chadwhitacre
added a commit
that referenced
this pull request
Apr 2, 2014
On #2226 I added a wireup._env function and used it under the hood in wireup to replace some older code. This commit brings configure-aspen into the mix. By introducing the env object into configure-aspen I'm setting us up to replace os.environ calls in other wireup functions with the env object.
This was referenced Apr 2, 2014
Merged
|
Is doing a |
|
Yes, that and |
|
Getting passes on everything 👍 Merging! |
rummik
added a commit
that referenced
this pull request
Apr 2, 2014
Switch to new environment.py library for config
Closed
chadwhitacre
added a commit
that referenced
this pull request
Apr 3, 2014
The wireup.{billing,nanswers} functions also need an env arg now.
Discovered in #2236.
seanlinsley
added a commit
that referenced
this pull request
Apr 6, 2014
Fix regression in payday with #2226 chain
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I factored out a new library called environment.py to manage configuration from environment variables. This commit replaces our former usage of the envvar function with environment. The next step is to replace all of our direct os.environ access.