Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Changes to implement DevNet #615

Closed
wants to merge 10 commits into from
Closed

Conversation

MikeFair
Copy link

@MikeFair MikeFair commented Feb 7, 2013

I've merged the updates as of this writing.

The code changes here create a new elsewhere network called DevNet which enables developers to log in as anyone in the system, create new userids, and claim any unclaimed users by logging in with the DevNet login.html page.

If the UserId doesn't already have a DevNet associated to their account, one will be added when they login for the first time.

You can now connect an existing Login to a DevNet login if you are already logged into it.
Still need to make it so you can sign in as another user without first having to associate a DevNet account.

Modified the DevNet login URLs to point at /on/devnet/login.html
(might drop the .html before we're done, and will likely delete redirect)
Next (and final?) step is that if an existing user tries to opt-in,
discover their account through the submitted screen_name and connect the DevNet account
rather than trying to create a new anonymous DevNet user.
Conflicts:
	gittip.py
	gittip/models/participant.py
	tests/test_elsewhere.py
	tests/test_pages.py
	www/on/confirm.html

Cleaned up conflicts
@MikeFair MikeFair mentioned this pull request Feb 8, 2013
@chadwhitacre
Copy link
Contributor

This is looking pretty good. A few comments:

  • I don't see a way in here to turn this off in production. We should require an explicit GITTIP_ENABLE_DEVNET key in os.environ, and either enable or disable DevNet based on that.
  • It looks like we're doing a lot more work than we need to for the login workflow here. Can we simplify that further for this case?
  • @lyndsysimon has started to build a modular /on/elsewhere/ infrastructure. We'll need for DevNet to use that when it's done. In fact, that might be a good way to handle the dev/production split: if /on/elsewhere/ is fully pluggable, then we can simply not install the DevNet plugin in production.

@chadwhitacre chadwhitacre mentioned this pull request Apr 7, 2013
@zbynekwinkler
Copy link
Contributor

Where is this standing? Right now we have neither DevNet nor modularized /on/, right? 😞

@chadwhitacre
Copy link
Contributor

Closing old pull requests in order to manage queue size.

@chadwhitacre
Copy link
Contributor

Reopening for the Infrastructure milestone.

@chadwhitacre chadwhitacre reopened this Sep 19, 2013
@ghost ghost assigned chadwhitacre Oct 12, 2013
@duckinator
Copy link
Contributor

This hasn't been worked on in over 11 months. What's the plan with this PR, going forward?

@chadwhitacre
Copy link
Contributor

@duckinator Good question. I'm going to close this one, because it sounds like we'll be moving forward with some kind of password authentication (#1052), and once we have that we won't need DevNet at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants