Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Multiple fixes for "ghost" diffs #5

Merged
merged 7 commits into from
Oct 28, 2022
Merged

Multiple fixes for "ghost" diffs #5

merged 7 commits into from
Oct 28, 2022

Conversation

dilchenko
Copy link
Contributor

@dilchenko dilchenko commented Oct 28, 2022

While current apply claims to finish successfully, if launched subsequently, terraform will claim to detect drift and require another apply - in a never ending loop. See https://app.terraform.io/app/Gravitational/workspaces/aws-terraform-infra-dev/runs/run-HX6y5y8tLT4zSiSZ for example.

This fixes some (hopefully, all) of the issues causing this:

Plan: https://app.terraform.io/app/Gravitational/workspaces/aws-terraform-infra-dev/runs/run-qQK4ZLDeR46zuBAg

@dilchenko dilchenko requested a review from reedloden October 28, 2022 05:15
@dilchenko dilchenko self-assigned this Oct 28, 2022
@dilchenko dilchenko requested review from gozer and removed request for reedloden October 28, 2022 05:15
auth_asg.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
acm.tf Show resolved Hide resolved
Copy link
Contributor

@gozer gozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the 2 small nits from @reedloden re: license_path and missing comment, this looks good and thank you for putting in effort to cleanup no-op plans 👏🏻

@dilchenko
Copy link
Contributor Author

I added a comment to the variable. WRT license_path, it is still used as a parameter for the auth server ASG. I don't know yet if it can be removed safely, it will be determined and dealt with later.

@dilchenko dilchenko merged commit 134f034 into master Oct 28, 2022
webvictim added a commit that referenced this pull request Dec 9, 2022
This was an oversight introduced in #5

Fixes #7
webvictim added a commit that referenced this pull request Jan 12, 2023
* Only do ACM cert validation if ACM is actually in use

This was an oversight introduced in #5

Fixes #7

* Usage of aws_route53_record.cert_validation needs to become aws_route53_record.cert_validation[0]

Co-authored-by: Philippe M. Chiasson <gozer@goteleport.com>
@wadells wadells deleted the dima/fixup_module branch September 22, 2023 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants