This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedloden
reviewed
Oct 28, 2022
gozer
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the 2 small nits from @reedloden re: license_path and missing comment, this looks good and thank you for putting in effort to cleanup no-op plans 👏🏻
I added a comment to the variable. WRT |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While current apply claims to finish successfully, if launched subsequently, terraform will claim to detect drift and require another apply - in a never ending loop. See https://app.terraform.io/app/Gravitational/workspaces/aws-terraform-infra-dev/runs/run-HX6y5y8tLT4zSiSZ for example.
This fixes some (hopefully, all) of the issues causing this:
aws_launch_template
not configuringmetadata_options
hashicorp/terraform-provider-aws#25909 (comment)Plan: https://app.terraform.io/app/Gravitational/workspaces/aws-terraform-infra-dev/runs/run-qQK4ZLDeR46zuBAg