Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Only do ACM cert validation if ACM is actually in use #8

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

webvictim
Copy link
Contributor

This was an oversight introduced in #5

Fixes #7

This was an oversight introduced in #5

Fixes #7
@webvictim webvictim requested review from dilchenko and gozer December 9, 2022 16:44
@webvictim webvictim self-assigned this Dec 9, 2022
@dilchenko
Copy link
Contributor

When I tried to fix #7, I am fairly certain this did not fix it. Did you try to run a plan with both am enabled and disabled?

@gozer
Copy link
Contributor

gozer commented Dec 9, 2022

Usage of aws_route53_record.cert_validation needs to become aws_route53_record.cert_validation[0]

@webvictim
Copy link
Contributor Author

I haven't tried to plan anything, this was reported by a customer who's using the module and found that things broke.

I'll see if I can get a sample setup going later.

@gozer
Copy link
Contributor

gozer commented Dec 18, 2022

When I tried to fix #7, I am fairly certain this did not fix it. Did you try to run a plan with both am enabled and disabled?

744446c should fix that

@webvictim webvictim merged commit ff3a7a9 into master Jan 12, 2023
@webvictim webvictim deleted the gus/fix-acm-cert-validation branch January 12, 2023 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACM certificate error following update
4 participants