Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Client does not check the error in GenerateToken #13925

Closed
narang99 opened this issue Jun 28, 2022 · 1 comment · Fixed by #13932
Closed

Go Client does not check the error in GenerateToken #13925

narang99 opened this issue Jun 28, 2022 · 1 comment · Fixed by #13932

Comments

@narang99
Copy link

Hey
I was trying to use the Go Client to generate tokens for nodes to join.
However, GenerateToken results in panic at this line, which I think is due to the error check miss. Due to this I'm not able to see the error message also.

The issue is with this line:

return resp.Token, trail.FromGRPC(err)

Thanks!

@zmb3
Copy link
Collaborator

zmb3 commented Jun 28, 2022

Thanks for reporting this. I've opened a PR to fix it.

zmb3 added a commit that referenced this issue Jun 28, 2022
Check error when generating tokens with the API client

Fixes #13925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants