Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10] Check error when generating tokens with the API client #13937

Merged
merged 4 commits into from
Jun 28, 2022
Merged

[v10] Check error when generating tokens with the API client #13937

merged 4 commits into from
Jun 28, 2022

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Jun 28, 2022

Backport #13932 to branch/v10

codingllama
codingllama approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@codingllama codingllama left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: LGTM

api/client/client.go Show resolved Hide resolved
@zmb3 zmb3 enabled auto-merge (squash) June 28, 2022 16:43
@zmb3 zmb3 merged commit 41b080a into branch/v10 Jun 28, 2022
@zmb3 zmb3 deleted the bot/backport-13932-branch/v10 branch June 28, 2022 22:02
@webvictim webvictim mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@greedy52 greedy52 greedy52 approved these changes

@r0mant r0mant Awaiting requested review from r0mant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmb3 @greedy52 @codingllama