TestWebSessionsRenewDoesNotBreakExistingTerminalSession flakiness

[Joerger]

Failure

Relevant snippet

This fails locally ~1/3 calls if you don't include the --race flag.

--- FAIL: TestWebSessionsRenewDoesNotBreakExistingTerminalSession (1.36s)
    apiserver_test.go:4693: 
        	Error Trace:	apiserver_test.go:4693
        	           				apiserver_test.go:3482
        	Error:      	Received unexpected error:
        	           	EOF
        	Test:       	TestWebSessionsRenewDoesNotBreakExistingTerminalSession

[Joerger]

This seems to be a weird race condition. Adding a second delay in the middle of apiserver.renewSession makes this error appear every time.

newSession, err := ctx.extendWebSession(r.Context(), req.AccessRequestID, req.Switchback)
if err != nil {
	return nil, trace.Wrap(err)
}
time.Sleep(time.Second)
newContext, err := h.auth.newSessionContextFromSession(newSession)
if err != nil {
	return nil, trace.Wrap(err)
}