[v10] Deflake TestWebSessionsRenewDoesNotBreakExistingTerminalSession #18530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
approved these changes
Nov 17, 2022
rosstimothy
approved these changes
Nov 18, 2022
|
Hmm, looks like Will investigate next week. |
Fixes two sources of flakiness in the test: 1. This test wasn't looking up the current OS user, and would try to start a session as a user that may not exist on the system. 2. It would run an `echo hello` command and search for `hello` in the terminal, but "hello" is also present in the command, so this resulted in false positives. Updates #15816
zmb3
force-pushed
the
bot/backport-18403-branch/v10
branch
from
372dba7 to
2d095b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #18403 to branch/v10