Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce react-in-jsx-scope ESLint rule #35027

Closed
wants to merge 1 commit into from

Conversation

ravicious
Copy link
Member

web/packages/shared/components/FieldSelect/shared.tsx did not include React in its scope which broke any story which made use of FieldSelect.

I'm ignoring e/web/teleport/src/AccessGraph/AccessGraph.tsx instead of fixing it because I don't have time to shepherd e changes and e ref updates + backports. Stories related to Access Graph are broken at the moment anyway, see https://github.com/gravitational/teleport.e/issues/2675.

@ravicious
Copy link
Member Author

Actually, shouldn't it be possible to make Storybook somehow import React automatically? https://stackoverflow.com/a/72259787/742872

@ravicious
Copy link
Member Author

Closing in favor of #35037

@ravicious ravicious closed this Nov 28, 2023
@ravicious ravicious deleted the ravicious/jsx-in-scope branch November 28, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v13 backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants