Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce react-in-jsx-scope ESLint rule #35027

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion web/packages/build/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ module.exports = {
'jest/no-large-snapshots': ['warn', { maxSize: 200 }],
},
},
// Overrides below exist only to avoid breaking the build. Remove them after addressing the
// issues in the underlying files.
{
files: ['e/web/teleport/src/AccessGraph/AccessGraph.tsx'],
rules: {
'react/react-in-jsx-scope': 0,
},
},
],
rules: {
'import/order': [
Expand Down Expand Up @@ -134,7 +142,7 @@ module.exports = {
'react/no-did-update-set-state': 1,
'react/no-unknown-property': 1,
'react/prop-types': 0,
'react/react-in-jsx-scope': 1,
'react/react-in-jsx-scope': 2,
'react/self-closing-comp': 0,
'react/sort-comp': 0,
'react/jsx-wrap-multilines': 1,
Expand Down
2 changes: 2 additions & 0 deletions web/packages/shared/components/FieldSelect/shared.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

import React from 'react';

export const defaultRule = () => () => ({ valid: true });

export const LabelTip = ({ text }) => (
Expand Down
1 change: 1 addition & 0 deletions web/packages/teleport/src/Assist/Conversation/Avatar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* limitations under the License.
*/

import React from 'react';
import styled from 'styled-components';

import teleport from 'design/assets/images/icons/teleport.png';
Expand Down
Loading