Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for landuse=education #774

Open
matthijsmelissen opened this issue Jul 28, 2014 · 77 comments
Open

Add rendering for landuse=education #774

matthijsmelissen opened this issue Jul 28, 2014 · 77 comments

Comments

@matthijsmelissen
Copy link
Collaborator

The following issue has been moved over from trac:

amenity=school should be used only for the actual facilities. but fellow mappers use it as a substitute for landuse, because it renders nicely in a yellowish color. the problem is, that search results then show two schools (one for the building and one for the area), because there there is not enough data to differentiate between the landuse and the actual school. it gets even worse, when different schools share one estate.

therefore i suggest that landuse=education should be rendered in the same color like amenity=school on areas to give mappers an alternative for defining/coloring the landuse and at the same time solving the problem with too many search results.

@matkoniecz
Copy link
Contributor

title is not matching text, text is duplicate of #773

@matthijsmelissen
Copy link
Collaborator Author

Thanks, fixed.

@matkoniecz
Copy link
Contributor

Used 389 times - http://taginfo.openstreetmap.org/tags/landuse=education

IMHO 1k uses is a good cutoff to even consider using a tag.

Also it is not documented on wiki what IMHO is also a necessary prerequisite.

@daganzdaanda
Copy link

I kind of like the semantics of landuse=education, but I'm not sure if we should "favour" it by rendering?

When I tag a school area, I try to use one area of amenity=school with name and address, and the building(s) get building=school, but not the name again.
What I don't like is when a school building has only amenity and no building tag...

@RobJN
Copy link

RobJN commented Jul 28, 2014

I disagree with the OPs tagging suggestion. I prefer to map amenity=school on the area and building=school for the individual buildings. This way you can give the school a name and name individual buildings. This becomes more important for university campuses.

I suggest closing this.

@pnorman
Copy link
Collaborator

pnorman commented Jul 28, 2014

389 uses for what is a very common feature, no wiki page.

@pnorman pnorman closed this as completed Jul 28, 2014
@Rovastar
Copy link
Contributor

I was just about to write what is the taginfo values and what is the wiki and editor status.
pnorman has done all that for me. :-)

@dieterdreist
Copy link

Am 29/lug/2014 um 01:29 schrieb RobJN notifications@github.com:

I suggest closing this.

+1

@SafetyIng
Copy link

Hey,

on the community there is a "new" approving of the landuse=education ; Link to the wiki

The voting is still very fresh. In the course of the weekend, the corresponding wiki pages will be adapted.
What does the carto team think about supporting the rendering? What do you think about the proposed rendering from the proposal? This would leed a lot to the transition strategy, that we would adapt.

@jeisenbe
Copy link
Collaborator

jeisenbe commented May 21, 2021 via email

@SafetyIng
Copy link

@jeisenbe

we will have to wait and see how this tag is used in the future and if it developed in a particular way that is no longer a duplicate of more common tags. At the moment it is too soon to consider rendering.

That is really bad.
There will be a lot mappers, That will lead to "mapping for the renderer", because landuse=education is not mapped yet..... A carto support would help to etablish the approved mapping.

@1ec5
Copy link

1ec5 commented May 22, 2021

The ink has barely dried on this approved proposal, so a little more patience is necessary. If even a fraction of the already mapped shared schoolgrounds were identified and dual-tagged with landuse=education, that would significantly strengthen the case for supporting landuse=education by itself in this renderer, which would in turn make mappers more comfortable with removing legacy amenity=school usage from those shared schoolgrounds. Of course, the difficult part is identifying shared schoolgrounds tagged as amenity=school, hence the proposal’s success.

@matkoniecz
Copy link
Contributor

matkoniecz commented May 22, 2021

And note that proposal explicitly planned

Transition strategy
For the time to transition: There is a suggestion to start adding landuse=education to current areas with amenity=school until enough uses lead to render support in Carto. It also gives other renderers time to change. When there is render support, the tag amenity=school can removed and landuse=education remains on the area.

Additional note: please do not retag blindly or run edits in violation of https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct - that can drastically damage any arguments based on tag usage count

@dieterdreist
Copy link

dieterdreist commented May 22, 2021 via email

@joelamos
Copy link

joelamos commented Jun 22, 2021

the difficult part is identifying shared schoolgrounds tagged as amenity=school, hence the proposal’s success.

Given this, I'm curious what criteria need to be met for rendering support. Is there some sampling technique that has been used elsewhere? Otherwise, the same arguments made above could be made in 10 years without any falsifiability.

@jdhoek
Copy link
Contributor

jdhoek commented Jul 5, 2021

Couldn't landuse=education be treated equal to landuse=religuous? The same concerns about mapping amenity=place_of_worship as nodes instead of areas applies there too, yet it is rendered.

That said, the goal of landuse=education isn't to replace single amenity=school entities mapped as area, but to add a way to map multiple educational facilities on shared grounds, and add a semantically meaningful way to map named educational areas (e.g., campuses). These multiple educational facilities on shared grounds tend to be mapped mapped as nodes already, so rendering landuse=education won't lead to mappers adopting bad practices.

An example:

Screenshot from 2021-07-05 21-18-01

(As per the proposal such areas are double tagged with amenity=school in the interim. Link to OSM)

This is a typical example of shared grounds and building, hosting two primary schools, a kindergarten, and a community centre. These are mapped as nodes, and cannot be meaningfully mapped as areas. Of course, in cases where multiples schools share grounds and have distinct exclusive areas for their own use within that, these can be mapped as areas within a larger landuse=education.

The previous solution adopted by many mappers was to simply (mis)use amenity=school for the grounds, despite it not representing an actual school. The landuse=education proposal offers a solution to that, and rendering it will allow the community to move on from the double-tagging-for-the-renderer.


It is explicitly not the goal of landuse=education to be used as the tag for the grounds of a single amenity=school with its own grounds, as amenity=school already implies landuse=education. This means that the vast majority of school are already tagged as they should be, with no need for explicit tagging of landuse=education. If the wiki doesn't make this clear we can improve that of course.

@joelamos
Copy link

joelamos commented Jul 5, 2021

@jdhoek I think everyone's clear on the purpose of landuse=education, it's just that the maintainers would like to see it get more actual use before rendering it.

@dieterdreist
Copy link

dieterdreist commented Jul 5, 2021 via email

@jdhoek
Copy link
Contributor

jdhoek commented Jul 5, 2021

(I'm not the proposal author, so I'm speaking purely as a supporter of this tag.)

I would consider a campus to be a specialized type of (named) educational landuse. I agree that it could do with an additional tag to add the actual 'campus' semantics, but that is no different from a campus tagged with amenity=university (in the ideal case of the extent of a university's grounds being also the most logical area for the amenity=* tag).

Landuses can in my experience be named, something which is frequently done with other types of landuse as well (e.g., retail or religious, and also residential — not in the sense of neighbourhoods of course, but for named developments or estates).

That was left outside of the scope of this proposal though. I don't think it is strange to further specify the type of educational landuse via a sub-key eventually if there is call for that — some mappers did suggest using a further education=* key for that.

@dieterdreist
Copy link

dieterdreist commented Jul 6, 2021 via email

@1ec5
Copy link

1ec5 commented Jul 6, 2021

landuse on its own will not get a name, because the name refers to a feature and not to a property.

This style already has a rule that labels landuse areas based on size, since it’s quite common to name landuse areas when they correspond to what’s named on the ground (for example, a named landuse=commercial area).

@dieterdreist
Copy link

dieterdreist commented Jul 6, 2021 via email

@jdhoek
Copy link
Contributor

jdhoek commented Jul 6, 2021

There are many named areas that fall below place=neighbourhood, or do not meet the definition of those place-tags. The named commercial area (retail is common too) is a good example of this. Named residential areas are common too, such as named developments (sometimes such names don't last long after construction finishes, sometimes they do). Named landuse is really, really common in OSM.

landuse=military is also a good example of named landuse where the type of area can be further refined via optional military=*. landuse=education seems similar to me.

@dieterdreist
Copy link

dieterdreist commented Jul 6, 2021 via email

@matheusgomesms
Copy link

It would seem like rendering this tag - in the same style as amenity=school - is a no-brainer.

If you have multiple schools on a campus, each with their own amenity=school tag, then it is obviously preferable to tag the larger campus area as landuse=education instead of another school tag just for the outline. Osm-carto should support this tagging by rendering it in the same way.

Exactly. The proposal (and further wiki pages) is well written and there was a lot of discussion regarding it. It was approved, there is a lot of usage now (despite not being rendered yet) and should be supported by OSM-carto. Period.

I know there is a lot of discussion on "carto is the main renderer, so we should be very wary about what we display" and while this is true, it is also true that this was WELL discussed previously, and it has gained popularity. What else should be done to be considered available to be rendered? Especially in a case like this, which seems fairly simple to render exactly like a school or university.

iD and JOSM are even supporting this tag already, so I would highly consider this issue to be reopened (and rendered, of course).

how would you do it, overlap with landuse=education or reduce the campus size?

The same way a mapper should use residential or commercial land use, when there is overlap of both usage in the same area.

@syntex1
Copy link

syntex1 commented Mar 12, 2022

Is 9067 enough to start rendering this tag? We do not have to wait for 10 000. https://taginfo.openstreetmap.org/search?q=landuse%3Deducation

@kocio-pl
Copy link
Collaborator

Yes. it looks like this issue is back on track and mature (lot of occurrences, wiki pages), so I reopen it.

Is anyone ready to prepare the code for this? That would make it a lot easier.

@kocio-pl kocio-pl reopened this Mar 12, 2022
@Choreuomai
Copy link

Would it be enough to insert [feature = 'landuse_education'] after line 578 in landcover.mss?

@kocio-pl
Copy link
Collaborator

Probably not, there is always a database counterpart in project.mml. It should be not too hard, however each time someone plans to make a PR, please always test it before proposing - see CONTRIBUTING.md and INSTALL.md.

jdhoek added a commit to jdhoek/openstreetmap-carto that referenced this issue Mar 15, 2022
Render `landuse=education` the same way as `amenity=school` etc.; this
is in line with the stated goals of this tag, and actively stimulates
mappers to stop abusing `amenity-school` to force rendering of shared
grounds.

Fixes gravitystorm#774
@jdhoek
Copy link
Contributor

jdhoek commented Mar 15, 2022

@kocio-pl @Choreuomai I've set up a PR. Are there any specific instances on the map of landuse=education you want to test?

@HolgerJeromin
Copy link
Contributor

https://www.openstreetmap.org/way/118272694 is IMO a typical scenario with its three schools inside.

@boothym
Copy link
Contributor

boothym commented Mar 15, 2022

Also, perhaps one for a new issue but on a related note based on the link above - it would be good for schools with a building tag to have their name rendered in the same way as with a school node on its own. Otherwise it just looks like a named building, e.g. https://www.openstreetmap.org/relation/3793902 compared to the Gesamtschule above it.

@Choreuomai
Copy link

Choreuomai commented Mar 16, 2022

Great, thank you so much Jeroen! But no, I cannot think of any special case that you might be unaware of.

@jdhoek
Copy link
Contributor

jdhoek commented Mar 16, 2022

@HolgerJeromin Good example. Unfortunately I am running into a rendering bug there with the text getting cut off. The issue exists on master when I tag that way with amenity=school and remove landuse=education too, so it is likely not related to this issue:

Screenshot from 2022-03-16 17-19-21

jdhoek added a commit to jdhoek/openstreetmap-carto that referenced this issue Mar 16, 2022
Render `landuse=education` the same way as `amenity=school` etc.; this
is in line with the stated goals of this tag, and actively stimulates
mappers to stop abusing `amenity-school` to force rendering of shared
grounds.

Fixes gravitystorm#774
@joshinils
Copy link

https://www.openstreetmap.org/way/87316791/
is not rendered, previously amenity=school

@Zaczero
Copy link

Zaczero commented Aug 14, 2023

https://wiki.openstreetmap.org/wiki/Tag:landuse=school
Is deprecated in favor of landuse=education.

@mfrasca
Copy link

mfrasca commented Sep 4, 2023

fixing a "school area" from amenity=school to landuse=education, the previous editor warns me I have removed the tagging that allowed rendering. in that area we have one building=school, in which in turn there's three different education institutes.
situations like the above are more rule than exception in Italy.

@dieterdreist

This comment was marked as off-topic.

@jdhoek

This comment was marked as off-topic.

@dieterdreist

This comment was marked as off-topic.

@jdhoek

This comment was marked as off-topic.

@imagico
Copy link
Collaborator

imagico commented Sep 4, 2023

Please no tagging discussion, you both know that.

@dieterdreist

This comment was marked as off-topic.

@dieterdreist
Copy link

dieterdreist commented Sep 4, 2023 via email

@mfrasca
Copy link

mfrasca commented Sep 4, 2023

I'm not discussing how to tag objects, I'm telling you that we need landuse=education to be rendered. people out there are tagging areas as amenity=school, resulting in cases like the one I'm reporting, where in reality we have 3 schools, but in the database it's 4: one node for each school, correctly tagged, then one area for the renderer.
if landuse=education were rendered, things would be better.

@dieterdreist

This comment was marked as off-topic.

@syntex1

This comment was marked as off-topic.

@dieterdreist

This comment was marked as off-topic.

@SafetyIng

This comment was marked as off-topic.

@imagico
Copy link
Collaborator

imagico commented Nov 7, 2024

I looked through the 29 cases returned by the query mentioned in #4524 (comment)

https://taginfo.openstreetmap.org/tags/?key=fixme&value=Remove+amenity%3Dschool+when+landuse%3Deducation+is+rendered

and these seem to confirm my previous assessment from #4524 (review)

Of the 29 polygons

  • 6 have no educational amenity=* inside.
  • 7 have a single educational amenity=* inside.
  • 12 have multiple educational amenity=* of the same type inside.
  • 4 have multiple educational amenity=* of different type inside.

That is 25/29 cases of use with umbrella tag meaning (to tag what is otherwise tagged as amenity=school, amenity=kindergarten, amenity=college etc. but with less specific meaning) - that is even more than the 2/3 estimated in #4524 (review) (though 29 is of course not representative).

This re-affirms my previous assessment from 2022:

If we'd seriously want to consider rendering this tag (in case its use improves in consistency and in semantic delineation towards the competing and much more widely used amenity=* tags) that would IMO have to:

  • be in a styling distinct from the educational amenity=* features so it is clear that it is not a synonym for them.
  • be in terms of prominence of rendering and in particular labeling clearly semantically subordinate to educational amenity=*. Our current way_area based polygon labeling is exactly the opposite of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.