Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rendering natural=desert #773

Closed
matthijsmelissen opened this issue Jul 28, 2014 · 13 comments · Fixed by #1200
Closed

Change rendering natural=desert #773

matthijsmelissen opened this issue Jul 28, 2014 · 13 comments · Fixed by #1200

Comments

@matthijsmelissen
Copy link
Collaborator

The following issue has been moved over from trac:

I know that till today the proposal of the desert feature is not approved ( http://wiki.openstreetmap.org/wiki/Proposed_features/Deserts) but it is rendered in Mapnik already.

The problem is the kind of way the desert is rendered today. The rendering doesn't make sense at all as you can see here: http://www.openstreetmap.org/?lat=30.374&lon=34.836&zoom=9&layers=M

The color 

The color needs to be changed as it doesn't make sense to show a desert that dark in brown. Desert should not be darker than a forest and as there is a lot of life and also villages in this area. The desert shouldn't be that present in Mapnik!

The desert name 
###### The name of the desert is not showing at all at the moment. This is of course not very helpful. If a big desert is defined it should on some zoomlevels show the name of the desert.
zoomlevel that show desert 

currently the zoomlevel = showing of desert doesn't make sense. The desert gets rendered already in zoom=8 in dark brown. The same way as the forest gets rendered in zoom=8. In zoom=9 the landuse farmland is rendered and in zoom=10 also landuse=sand is added. It looks very much like a swiss cheese.

In zoom=13 there is no desert rendered anymore.

###### Summary

The whole concept of showing the desert has to be reconsidered. The current displaying doesn't make so much sense.

We consider in Israel to remove the whole desert just because it is showing this strange way. I know that we shouldn't map to a renderer but in this case it looks just to bad to keep it this way.

Please see this thread in the discussion board: http://forum.openstreetmap.org/viewtopic.php?id=14806

@matkoniecz
Copy link
Contributor

tile.openstreetmap.fr fork is doing this well

@imagico
Copy link
Collaborator

imagico commented Jul 28, 2014

See also http://wiki.openstreetmap.org/wiki/Talk:Tag:natural%3Ddesert

Current desert polygon data is mostly an exercise at abstract art, like:

http://www.openstreetmap.org/#map=8/28.060/-3.521
http://www.openstreetmap.org/#map=8/26.547/45.604

The global average node distance of desert areas is probably something like 20-50 kilometers and i have yet to see any area tagged natural=desert that is properly mapped under any universal definition of desert. Rendering landforms like deserts which naturally have no well defined boundaries as colored polygons does not really make much sense, especially not at zoom levels >= 8. I would have suggested removing those from the style long ago but sadly i see no real chance in such a suggestion being successful.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Aug 1, 2014
The minimum zoom levels are currently rather inconsistent. For example meadow
and farmland have a different minimum zoom level. This PR aims to improve this.

This PR lets all major landuse start at z10 (like most do already), except for
wood / forest. Smaller objects will start at z10.

Concrete changes in minimum zoom levels:

* tourism=camp_site, tourism=caravan_site, tourism_picnic_site from z13 to z10
* landuse=quarry from z11 to z10
* landuse=garages from z12 to z13
* landuse=farmyard, landuse=farm, landuse=farmland from z9 to 10
* landuse=village_green from z11 to z10
* natural=desert from z8 to z10 (solves partially gravitystorm#773)
* aeroway=apron, aeroway=aerodrome from z12 to z10
* highway=services, highway=rest_area from z14 to z10
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Aug 1, 2014
The minimum zoom levels are currently rather inconsistent. For example meadow
and farmland have a different minimum zoom level. This PR aims to improve this.

This PR lets all major landuse start at z10 (like most do already), except for
wood / forest. Smaller objects will start at z13.

Concrete changes in minimum zoom levels:

* tourism=camp_site, tourism=caravan_site, tourism_picnic_site from z13 to z10
* landuse=quarry from z11 to z10
* landuse=garages from z12 to z13
* landuse=farmyard, landuse=farm, landuse=farmland from z9 to 10
* landuse=village_green from z11 to z10
* natural=desert from z8 to z10 (solves partially gravitystorm#773)
* aeroway=apron, aeroway=aerodrome from z12 to z10
* highway=services, highway=rest_area from z14 to z10
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Aug 7, 2014
The minimum zoom levels are currently rather inconsistent. For example meadow
and farmland have a different minimum zoom level. This PR aims to improve this.

This PR lets all major landuse start at z10 (like most do already), except for
wood / forest. Smaller objects will start at z13.

Concrete changes in minimum zoom levels:

* tourism=camp_site, tourism=caravan_site, tourism_picnic_site from z13 to z10
* landuse=quarry from z11 to z10
* landuse=garages from z12 to z13
* landuse=farmyard, landuse=farm, landuse=farmland from z9 to 10
* landuse=village_green from z11 to z10
* natural=desert from z8 to z10 (solves partially gravitystorm#773)
* aeroway=apron, aeroway=aerodrome from z12 to z10
* highway=services, highway=rest_area from z14 to z10
@matkoniecz
Copy link
Contributor

i have yet to see any area tagged natural=desert that is properly mapped under any universal definition of desert

Can somebody provide counterexample? Because it would be a good point againt rendering natural=desert.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Oct 12, 2014
@matthijsmelissen
Copy link
Collaborator Author

I think many uses of natural=desert, at least in Africa and Australia, try to cover the concert of an Erg.

They are also sometimes tagged as natural=sand. Perhaps that's the better tag?

Or we can just concur that natural=desert does not refer to the climatological definition of desert, but to the "folk-definition" of desert, which seems to basically equal sand dunes / ergs.

It is not entirely clear to me what the tag natural=desert in the United States tries to convey, though.

@imagico
Copy link
Collaborator

imagico commented Oct 12, 2014

In Northern Africa and the Middle East many desert polygons roughly follow the sand deserts but this is not generally the case elsewhere. Especially in the Basin and Range Province in North America the desert tag is commonly used for the valleys which only rarely contain significant sand areas. This can also be seen in the name tags (see for example: http://www.openstreetmap.org/#map=10/38.0551/-116.6446).

@matthijsmelissen
Copy link
Collaborator Author

Yes, that's basically what I said, right? :)

Why do Americans see the valleys as desserts? I suppose the climate is basically the same as in the ridges in between? Is the difference based on vegetation?

@imagico
Copy link
Collaborator

imagico commented Oct 12, 2014

These valleys are in many cases deserts in the sense they are fairly dry and with only sparse vegetation while precipitation is higher in the mountain ranges around resulting in more vegetation there. But the polygons are fairly crude and do not usually map the vegetation divisions but the topography.

Typical appearance is like this:

http://commons.wikimedia.org/wiki/File:2014-07-18_17_26_54_Panorama_of_Railroad_Valley_from_U.S._Route_6_eastbound_about_90.8_miles_east_of_the_Esmeralda_County_Line_in_Nye_County,_Nevada.JPG
http://commons.wikimedia.org/wiki/File:2013-09-19_11_43_59_View_west_from_Nevada_State_Route_376_across_Big_Smoky_Valley.JPG

The few sand deserts that exist there are usually mapped as natural=sand like here:

http://www.openstreetmap.org/#map=12/36.6531/-116.5584
http://www.openstreetmap.org/#map=11/35.6832/-116.2649

@pnorman
Copy link
Collaborator

pnorman commented Oct 13, 2014

I'd consider those two fairly typical deserts in my experience.

A few years back I went on a camping trip through the Australian outback, which took me through the edges of deserts, and it was somewhat similar.
The first is typical of the view in the day
https://commons.wikimedia.org/wiki/File:Tanami_Track_23rd_June.jpg
https://commons.wikimedia.org/wiki/File:MVC-684F.JPG
https://commons.wikimedia.org/wiki/File:Gibson_Desert_and_moon_from_Alfred_%26_Marie_Range.jpg

I'm not sure what typical use of natural=desert is.

@matkoniecz
Copy link
Contributor

Problems with natural=desert is that (almost?) always it is completely impossible to show line with desert on one side and not a desert on the other. Wiki page documents why this is a bad tag. I am now convinced that this tag should not be rendered.

@matthijsmelissen
Copy link
Collaborator Author

Problems with natural=desert is that (almost?) always it is completely impossible to show line with desert on one side and not a desert on the other.

Ergs (sand deseets) have very sharp borders though.

@matkoniecz
Copy link
Contributor

Ergs (sand deseets) have very sharp borders though.

Maybe, but natural=desert, in name, definition and usage includes also other kinds of terrain.

@daganzdaanda
Copy link

Interesting topic.
I kind of like the part of the linked proposal that has "desert=x" similar to "wetland=x". But I can agree that "natural=sand|scree|bare_rock" should be used, instead of a new scheme. There might be some more tags missing (especially for different types of scrub landscape (density?)), but "natural=desert" then should really be removed from rendering.

If we wanted to keep rendering "natural=desert", I would make it much more neutral and grey-ish. Or outline the area, similar to national parks, to show the extent of the whole "desert" area, no matter what the exact parts of it are.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Oct 18, 2014
Ergs (sand dunes) are better tagged as natural=sand.
Other type of dunes don't have strict borders.

This resolves gravitystorm#773.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Nov 6, 2014
Ergs (sand dunes) are better tagged as natural=sand.
Other type of dunes don't have strict borders.

This resolves gravitystorm#773.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Nov 15, 2014
Ergs (sand dunes) are better tagged as natural=sand.
Other type of dunes don't have strict borders.

This resolves gravitystorm#773.
@mboeringa
Copy link

The global average node distance of desert areas is probably something like 20-50 kilometers and i have yet to see any area tagged natural=desert that is properly mapped under any universal definition of desert. Rendering landforms like deserts which naturally have no well defined boundaries as colored polygons does not really make much sense, especially not at zoom levels >= 8. I would have suggested removing those from the style long ago but sadly i see no real chance in such a suggestion being successful.

Problems with natural=desert is that (almost?) always it is completely impossible to show line with desert on one side and not a desert on the other. Wiki page documents why this is a bad tag. I am now convinced that this tag should not be rendered.

Fully agree with these observations about the the near total impossibility to define exact and meaningful boundaries for deserts, and that is why almost no map shows an outline or polygon fill for deserts, but just a label showing the "approximate" location of the desert.

And that is the way natural=deserts should be rendered, IMO. Look at the attached image, at scale 1:1M. Combined with contours, the OSM desert data starts to make sense. Dropping the rendering of natural=desert completely, including labelling, will lead to a significant loss in some areas like the Western US.

Admittedly, contours are vital for making sense of the labels... but that is true for many other rendered "landform" related features like cliffs, ridges, peaks etc.

The "kaki" brown patches by the way in some of the desert valleys, are patches of natural=mud as tagged in OSM. They actually seem to correspond with the nearly flat lower sections of the valleys, below the screes running of the side of the mountains, quite well, as can be seen in this Google Maps link of the same area:

https://www.google.nl/maps/place/Death+Valley,+Verenigde+Staten/@36.2284306,-116.297554,227091m/data=!3m1!1e3!4m2!3m1!1s0x80c739a21e8fffb1:0x1c897383d723dd25

natural_desert_western_us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment