Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop rendering for landuse=field, military=barracks, and natural=desert #1200

Merged

Conversation

matthijsmelissen
Copy link
Collaborator

Rationale for military=barracks:
We have landuse=military for the area already, and the buildings
themselves are just as well rendered as regular builidings.

Rationale for landuse=desert:
Ergs (sand dunes) are better tagged as natural=sand.
Other type of deserts don't have strict borders.

Rationale for landuse=field:
This is duplicate with landuse=farmland and landuse=grass.

Resolves #589.
Resolves #773.
Resolves #1053 (superceded).
Resolves #1072 (superceded).
Resolves #1074 (superceded).

We have landuse=military for the area already, and the buildings
themselves are just as well rendered as regular builidings.
Ergs (sand dunes) are better tagged as natural=sand.
Other type of dunes don't have strict borders.

This resolves gravitystorm#773.
This is duplicate with landuse=farmland and landuse=grass.

This resolves gravitystorm#589.
Conflicts:
	landcover.mss
	project.mml
	project.yaml
@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 6, 2015

+1 for dropping military=barracks.

@nebulon42
Copy link
Contributor

+1
Field is already rendered like farmland, right? Why is it duplicate with grass?

@matkoniecz
Copy link
Contributor

Note also that http://wiki.openstreetmap.org/wiki/Tag:military%3Dbarracks has "Status: Unspecified", http://wiki.openstreetmap.org/wiki/Tag:landuse%3Dfield describes tag as abandoned and rejected, http://wiki.openstreetmap.org/wiki/Tag:natural%3Ddesert is mainly warning that it is not verifiable.

@matkoniecz
Copy link
Contributor

Also, maybe there is some potential in using natural=desert for labels but it requires at least (1) improving natural=desert proposal, including solving "deserts don't have strict borders" problem, (2) finding method to properly display labels for large scale features (at least repeating labels are necessary).

matkoniecz pushed a commit that referenced this pull request Jan 6, 2015
Drop rendering for landuse=field, military=barracks, and natural=desert
@matkoniecz matkoniecz merged commit a67327d into gravitystorm:master Jan 6, 2015
@matthijsmelissen matthijsmelissen deleted the drop-barracks-desert-field branch January 7, 2015 01:58
@dieterdreist
Copy link

2015-01-06 1:00 GMT+01:00 math1985 notifications@github.com:

Rationale for military=barracks:
We have landuse=military for the area already, and the buildings
themselves are just as well rendered as regular builidings.

I'd render a name for military=barracks. This is not to be confused with
landuse=military, which doesn't constitute an entity (like barracks does,
which are typically named, fenced etc.), but is rather a landuse attribute
for an area (e.g. can be arbitrarily split without loosing information),
i.e. it tells that the main usage of the tagged area is by the military,
but it doesn't tell for what it is used.

Please note that barracks can be very big features, useful for orientation
and "advertized" by street signs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change rendering natural=desert landuse=field/natural=field
5 participants