Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger symbol rework in SVG #2739

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Danger symbol rework in SVG #2739

merged 1 commit into from
Aug 15, 2017

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Aug 12, 2017

Trying to resolve one of the problems from #937.

The easiest thing would be to add 2 pixels h/w to danger.png. More desirable would be to recreate it in SVG.

I made a background to make it look the same, however the question is if we want this background or was it just a leftover we should get rid of:

Example at z13:

Before
danger-png
After (with background)
danger-svg-bg
After (without background)
danger-svg-nobg

@kocio-pl
Copy link
Collaborator Author

We can also change background opacity. For example with polygon-opacity: 0.5; it looks like:
wbvhgvps
Opacity 0.6:
bj7xvrpa
Opacity 0.7:
4ypbe8 k

@matthijsmelissen
Copy link
Collaborator

Perhaps we should decide on #684 and #2670 first?

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a wider solution that deals with all the military/danger_area rendering issues at once.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 12, 2017

Since these discussions are quite big and not active for at least a month, I think we could merge this as it is (making just PNG->SVG and 30px->32px change) to fix smaller issue. This would also allow to test new color ideas more easily than raster editing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants