-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made landuse=military areas less prominent #3035
Conversation
Can you add some before/after images? |
When removing the outline we cannot see the boundary of the feature, in particular when it is not identical to other underlying features. |
We were discussing making all the uniform services areas look the same (military, police and fire services). The proposition was to get rid of hatching and leave just a red area - with the red outline (by default, because we were not thinking about more changes). Recent experiments with museum outline show, that the outline should be specific in order to make a fence visible, if it's present. Could anybody show how the outline of a military area looks like with a fence currently? |
Military with fence is well visible since the grey contrasts against the pink: |
I will upload additional screenshots in the evening. One interesting use case is near Farnborough, with eg several overlapping military areas. I am not too attached to this particular proposal. I just consider current rendering of military areas way too prominent. I didn't get rid of hatching because I thought that may be one change too much. Besides, IMHO military areas should not be treated like other land uses. Especially in certain countries. I was thinking about leaving 1px border (2px is still quite obnoxious, in my opinion) but then I realised removing the border entirely works just fine. We need some transparency in the fill/hatching pattern to display overlapping areas but that's all. No border or 1px border should also work better with fences. Fill pattern was made a bit more transparent because there are often quite many mapped objects inside these areas and the previous fill pattern was obscuring them. Filtering settings were made more aggressive to prevent large numbers of small areas from dotting the map at medium zoom levels. It is analogous to the airport/airfield issue discussed in another ticket. |
I agree with reducing military, just it needs to be in sync with our plans for police etc. We could use the outline without the hatching. |
General note: I'm happy that you both are really testing these things! That's what is needed in my opinion. I don't see the fence on the military outline, but it looks like the problem no one really notice, since it was not reported as of now - so maybe it's not that important? However if there is a way to make the difference visible somehow, it's preferable. |
So, how about:
If that's OK, I will update the PR. Details can always be later refined to match police and fire services etc. |
@kocio-pl - how do we distinguish the military from the other uniformed services when they have only the same outline? If we renew hatching style for whatever, it might make sense to drop the light pink in the hatching gaps (make them clear), since its transparency merges colours with underlying landuse which is frowned upon in this style. |
I am OK with using only 1px border for small areas (in pixels). For larger areas (in pixels) we need either tinting or hatching, as we may see only part of the border. In both cases the fill should be unobtrusive. I don't consider a color shift a problem. In fact, IMHO, it would be good to have eg commercial areas tint building colors, but that's a topic for another discussion. Hatching or tinting is really an aesthetic matter, with hatching being a "low tech" substitute to tinting. It is just down to an arbitrary decision. |
The same as we distinguish schools from other societal amenities: they have no icon, while the rest have some. |
First please show how would it look like then, so we could judge the result. |
I don't see hatching as "low tech". Removing/avoiding colour merging effects was a main goal in this style for quite a while (I wonder if that is documented?). The style has subtle differences in the same colour group that get lost when colours merge. |
In case anybody coming here from weeklyOSM 393 ( http://www.weeklyosm.eu/archives/9939 ) - this issue was closed by its author without merging, so it will certainly not affect next release of osm-carto. |
I'm here from weeklyOSM 393, just like to say that I was hoping this would go ahead as current style needs fixing. |
The problem is not neglected, just check #3045 and help us there to decide and test solutions. |
New proposal is in PR #3057. |
Ref #2670
Made landuse=military areas less prominent by: