Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document SANs in certificates #1112

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Document SANs in certificates #1112

merged 2 commits into from
Sep 18, 2024

Conversation

john-floren-gravwell
Copy link
Collaborator

Addresses #1110

kris-watts-gravwell
kris-watts-gravwell previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@kris-watts-gravwell kris-watts-gravwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-floren-gravwell
Copy link
Collaborator Author

ptal

keith-smiley-gravwell
keith-smiley-gravwell approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@keith-smiley-gravwell keith-smiley-gravwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keith-smiley-gravwell keith-smiley-gravwell merged commit 32a6109 into gravwell:dev Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-smiley-gravwell keith-smiley-gravwell keith-smiley-gravwell approved these changes

@kris-watts-gravwell kris-watts-gravwell kris-watts-gravwell left review comments

Assignees

@keith-smiley-gravwell keith-smiley-gravwell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@john-floren-gravwell @kris-watts-gravwell @keith-smiley-gravwell @floren