Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspended tab doesn't automatically unsuspend after closing another tab #519

Closed
sunspeck opened this issue Jun 7, 2017 · 22 comments
Closed

Suspended tab doesn't automatically unsuspend after closing another tab #519

sunspeck opened this issue Jun 7, 2017 · 22 comments
Labels
feature waiting-on-release
Milestone
Chrome webstore 7...

Comments

@sunspeck
Copy link

sunspeck commented Jun 7, 2017

The latest update to this great extension seems to have introduced a bug / removed a desirable behavior.

I have it set to "Automatically unsuspend tab when it is viewed."

Previously, this would unsuspend tabs when they are clicked on, and also unsuspend a newly focussed tab when the previous tab is closed (via keyboard shortcut or [X] button).

The new update will no longer automatically unsuspend the next tab when a tab is closed. To unsuspend the next tab I must manually switch away from it and then switch back.

I found the original way this was handled to be much more intuitive, useful, and effective.

Thanks!
@poulhansen
Copy link

poulhansen commented Jun 8, 2017 •
edited
Loading

It's the same here although sometimes it works.
It happened after my screen showed an "update" to the program.
It works when clicking the tab but not after closing the previous tab, then the new tab that emerges, stays suspended.

@deanoemcke deanoemcke mentioned this issue Jun 8, 2017
Closed
@deanoemcke
Copy link
Collaborator

I have updated the issue title to be more specific as it looks like clicking on a suspended tab does automatically unsuspend it. It is only failing when a tab is closed and a suspended tab is shown in its place.

@deanoemcke deanoemcke changed the title Bug: Viewed tab won't automatically unsuspend under all conditions Bug: Suspended tab doesn't automatically unsuspend after closing another tab Jun 8, 2017
@deanoemcke deanoemcke changed the title Bug: Suspended tab doesn't automatically unsuspend after closing another tab Suspended tab doesn't automatically unsuspend after closing another tab Jun 8, 2017
@deanoemcke
Copy link
Collaborator

lol. i just came across this other issue which tidying up: #114

it requests that suspended tabs that gain focus after anther tab is closed should not automatically unsuspend. i agreed with the user at the time, hence the change in functionality.
it's not a bug, it's a feature!

i guess the long-term solution is to have this as a configurable option.

@sunspeck
Copy link
Author

sunspeck commented Jun 9, 2017

Hi, I only realized after I posted this what you were already dealing with regarding the security issue, yikes.

After living with this new behavior for a few days, and turning on the screen capture function to cope with it, I can sorta see how it would be desirable at times. But a configurable option allowing auto-unsuspend after tab close would definitely be enjoyed by those of us who open a stack of tabs to read the morning news.

Anyway, many thanks for this fine plugin which has saved my Macbook from a most certain heat death.

@liamjohnston liamjohnston mentioned this issue Jun 12, 2017
Closed
@acidlung
Copy link

I agree with sunspeck that the previous behavior (automatically unsuspending focused tabs rather than forcing a click) was more intuitive. Since I usually have 20 tabs open and am doing research, when I revert to a suspended tab, I almost always want to view it. Admittedly, that is MY personal workflow and my style is probably in the minority. That said, I'm the type of user that realizes huge benefits from your excellent extension and doesn't mind diving into the settings screen to really dial things in. Others obviously have a different use case.
I enthusiastically agree that making this behavior into a setting would be hugely helpful for me and make all parties happy. Also it should likely default to the current behavior since users seem to prefer it, judging by the fact that only a few have filed an issue since you changed it.

@deanoemcke deanoemcke mentioned this issue Jul 19, 2017
Closed
@smilejack1
Copy link

My work habits are like acidlung's, and would greatly prefer either a reversion to the previous behavior or to have such behavior as an option. As much as I appreciate this extension, it is much less helpful to me than it was.

deanoemcke added a commit that referenced this issue Aug 18, 2017
@deanoemcke
Reenable auto reload of suspended tabs that receive focus after the c…
3e20811 
…losing of another tab (#519)
@deanoemcke
Copy link
Collaborator

After some deliberation, I have decided to revert this functionality back to how it used to be. Any suspended tab that gains focus will now automatically reload, regardless of whether the focus was gained via the closing of another tab.
The main reason for this decision was consistency. It appeared to be too much like a bug the way it currently operated. And I'm not sure the number of people in favour or against this feature is significant either way.

@poulhansen
Copy link

poulhansen commented Aug 18, 2017 via email

deanoemcke added a commit that referenced this issue Aug 18, 2017
@deanoemcke
Reenable auto reload of suspended tabs that receive focus after the c…
7a5afa6 
…losing of another tab (#519)
@deanoemcke deanoemcke mentioned this issue Oct 24, 2017
Closed
@deanoemcke deanoemcke mentioned this issue Nov 27, 2017
Open
@liamjohnston liamjohnston mentioned this issue Dec 21, 2017
Closed
@deanoemcke deanoemcke mentioned this issue Feb 7, 2018
Closed
@deanoemcke deanoemcke mentioned this issue Apr 17, 2018
Closed
@draarong
Copy link

@deanoemcke I'm really glad you decided that a tab gaining focus after another tab is closed should be automatically unsuspended...But it doesn't seem to work for me! Has something changed w/more recent versions of MacOS or Chrome?

@mcmasjc3
Copy link

mcmasjc3 commented May 11, 2018 via email

@smilejack1
Copy link

Has never worked for me, either.

@draarong
Copy link

Hey @deanoemcke , did you know that this function isn't working, at least on MacOS?

@mcmasjc3
Copy link

mcmasjc3 commented May 13, 2018 via email

@deanoemcke
Copy link
Collaborator

@draarong @mcmasjc3 @smilejack1
really? it seems to work for me?
just to confirm:

  • you have 'Automatically unsuspend tab when it is viewed' checked.
  • you visit a suspended tab by clicking on it.
  • it automatically unsuspends.
  • you close that tab and chrome brings another suspended tab in focus.
  • this tab does not automatically unsuspend?

this is working fine for me on v7.0.90. ie: it does automatically unsuspend the tab in the last step.

can each of you please go through the above steps and confirm that this does not work? and also record the version of the extension you are using?

thanks!

@mcmasjc3
Copy link

mcmasjc3 commented May 23, 2018 via email

@mcmasjc3
Copy link

mcmasjc3 commented May 24, 2018 via email

@t0m05
Copy link

t0m05 commented Aug 30, 2018

it requests that suspended tabs that gain focus after anther tab is closed should not automatically unsuspend. i agreed with the user at the time, hence the change in functionality.
it's not a bug, it's a feature!
i guess the long-term solution is to have this as a configurable option.

After some deliberation, I have decided to revert this functionality back to how it used to be. Any suspended tab that gains focus will now automatically reload, regardless of whether the focus was gained via the closing of another tab.
The main reason for this decision was consistency. It appeared to be too much like a bug the way it currently operated. And I'm not sure the number of people in favour or against this feature is significant either way.

I recently got the update and think TGS is generally one of the greatest extensions I use.
However, when it comes to this issue, I have to say I prefer the previous functionality. I don't see why closing one tab should unsuspend the next (unrelated) tab to get focus.
I accept that others have voiced a different opinion based on their workflow, so I would be all for it being a configurable option.

This was referenced Sep 2, 2018
Open
Closed
@deanoemcke
Copy link
Collaborator

@t0m05 i have created a new issue requesting the ability to make this a configurable behaviour: #747

@t0m05
Copy link

t0m05 commented Oct 2, 2018

@t0m05 i have created a new issue requesting the ability to make this a configurable behaviour: #747

Thanks! 👍

@deanoemcke deanoemcke added this to the Chrome webstore 7.1 release milestone Feb 6, 2019
@mcmasjc3
Copy link

mcmasjc3 commented Feb 6, 2019 via email

@deanoemcke
Copy link
Collaborator

@mcmasjc3 Can you please check a few things for me?

  1. Tell me the version of TGS you are using
  2. Ensure 'Automatically unsuspend tab when it is viewed' is checked
  3. Open a new chrome window and navigate to a website and then suspend that tab while looking at it
  4. Create a new tab in that same window (so you have just 2 tabs in that window) and then close it again immediately.
  5. Confirm that the suspended tab unsuspends automatically (or not :/ )

Thanks :)

@mcmasjc3
Copy link

mcmasjc3 commented Feb 8, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature waiting-on-release
Projects
None yet
Milestone
Chrome webstore 7.1 release
Development

No branches or pull requests
8 participants
@sunspeck @deanoemcke @acidlung @draarong @smilejack1 @poulhansen @mcmasjc3 @t0m05