Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh_CN translation #872

Merged
merged 1 commit into from
Mar 4, 2019
Merged

update zh_CN translation #872

merged 1 commit into from
Mar 4, 2019

Conversation

shkey
Copy link
Contributor

@shkey shkey commented Feb 26, 2019

I took a moment to update all the simplified Chinese translations.

@deanoemcke
Copy link
Collaborator

@shkey wow, this is quite a major rewrite! how confident are you of the changes you are making? my expertise is limited to google translate so I have no way of telling!

also, does this mean that the traditional chinese translations are probably incorrect too?

@hermanho @goodjack @neighborhood999 do you have any comment on this PR?

@shkey
Copy link
Contributor Author

shkey commented Feb 28, 2019

@deanoemcke To be honest, I have made tremendous changes, most of which are basic vocabulary rather than sentence meanings. Although, I can't make the promise that my version is perfect, it's still the most suitable "Simplified Chinese Translation". As for it's correctness, I may promise you. Then, I would like to say something about the "Traditional Chinese Translation". I believe that I'm not qualified to make such comments for I'm not familiar with it. However, I may make an emphasis on the fact that both "SCT" and "TCT" have their own way of translation. "Tab", for example, we may translate it into "标签页" in "SCT" while we can call it "分页" in "TCT". To draw a conclusion, one size doesn't fit all. Habitual differences always occur in these two kinds of translations. And, if you want to make sure whether the current "TCT" is right or not, you'd better find a local person.

@hermanho
Copy link
Contributor

hermanho commented Mar 1, 2019

@deanoemcke I will have a look on traditional chinese.

@hermanho
Copy link
Contributor

hermanho commented Mar 1, 2019

@deanoemcke Are the these string obsoleted?
"html_suspended_modal_header",
"html_suspended_modal_this_domain",
"html_suspended_modal_this_page",
"html_suspended_modal_temp_whitelist",
"html_suspended_modal_temp_whitelist_notice",
"html_suspended_modal_ok"

@deanoemcke
Copy link
Collaborator

@hermanho thanks!
and yes, those modal strings are obsolete.

hermanho added a commit to hermanho/thegreatsuspender that referenced this pull request Mar 1, 2019
hermanho added a commit to hermanho/thegreatsuspender that referenced this pull request Mar 1, 2019
hermanho added a commit to hermanho/thegreatsuspender that referenced this pull request Mar 1, 2019
hermanho added a commit to hermanho/thegreatsuspender that referenced this pull request Mar 1, 2019
hermanho added a commit to hermanho/thegreatsuspender that referenced this pull request Mar 2, 2019
hermanho added a commit to hermanho/thegreatsuspender that referenced this pull request Mar 2, 2019
hermanho added a commit to hermanho/thegreatsuspender that referenced this pull request Mar 2, 2019
@goodjack
Copy link
Contributor

goodjack commented Mar 4, 2019

It looks great!

@deanoemcke deanoemcke merged commit ae36441 into greatsuspender:master Mar 4, 2019
@deanoemcke
Copy link
Collaborator

@shkey thanks so much for this

@shkey
Copy link
Contributor Author

shkey commented Mar 5, 2019

@deanoemcke It's my pleasure. By the way, how long will it take for the next version to be released?

@deanoemcke
Copy link
Collaborator

@shkey i'd like to say the next week. but i've been saying that for months. there's just testing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants