Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated sys_siglist with strsignal #2513

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Replace deprecated sys_siglist with strsignal #2513

merged 1 commit into from
Oct 19, 2020

Conversation

tgurr
Copy link
Contributor

@tgurr tgurr commented Oct 16, 2020

Required to work with glibc >= 2.32.

https://sourceware.org/pipermail/libc-announce/2020/000029.html

The deprecated arrays sys_siglist, _sys_siglist, and sys_sigabbrev
are no longer available to newly linked binaries, and their declarations
have been removed from <string.h>. They are exported solely as
compatibility symbols to support old binaries. All programs should use
strsignal instead.

What: Same as greenbone/gvmd#1280

Why: Same as greenbone/gvmd#1280

How: Same as greenbone/gvmd#1280

Checklist:

@tgurr tgurr requested a review from a team October 16, 2020 12:01
@tgurr tgurr changed the base branch from master to gsa-20.08 October 16, 2020 12:01
Required to work with glibc >= 2.32.

https://sourceware.org/pipermail/libc-announce/2020/000029.html

  The deprecated arrays sys_siglist, _sys_siglist, and sys_sigabbrev
  are no longer available to newly linked binaries, and their declarations
  have been removed from <string.h>. They are exported solely as
  compatibility symbols to support old binaries. All programs should use
  strsignal instead.
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #2513 into gsa-20.08 will increase coverage by 0.31%.
The diff coverage is 77.09%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2513      +/-   ##
=============================================
+ Coverage      52.76%   53.07%   +0.31%     
=============================================
  Files           1070     1072       +2     
  Lines          25789    25896     +107     
  Branches        7312     7372      +60     
=============================================
+ Hits           13607    13744     +137     
+ Misses         11058    11030      -28     
+ Partials        1124     1122       -2     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/gmp/models/tlscertificate.js 100.00% <ø> (ø)
gsa/src/web/components/error/errorpanel.js 100.00% <ø> (ø)
gsa/src/web/pages/alerts/dialog.js 20.33% <ø> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/policies/detailspage.js 100.00% <ø> (ø)
gsa/src/web/pages/policies/row.js 100.00% <ø> (ø)
gsa/src/web/pages/portlists/detailspage.js 34.48% <ø> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ee110...3752592. Read the comment docs.

@bjoernricks bjoernricks merged commit 17a736a into greenbone:gsa-20.08 Oct 19, 2020
@bjoernricks
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants