-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated sys_siglist with strsignal #1280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
If you want this in the next 20.08 release then please submit a PR against gvmd-20.08 instead.
And would be great if you could add a CHANGELOG.md entry.
I'll open a follow-up PR once this is through.
Added. |
|
I think just gvmd-20.08 would be easier, because we'll merge that to master. |
Took me a moment to figure out, I hope I did everything correctly switching the PR to gvmd-20.08. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's great, thank you.
One nitpick left, just noticed the missing spaces.
Required to work with glibc >= 2.32. https://sourceware.org/pipermail/libc-announce/2020/000029.html The deprecated arrays sys_siglist, _sys_siglist, and sys_sigabbrev are no longer available to newly linked binaries, and their declarations have been removed from <string.h>. They are exported solely as compatibility symbols to support old binaries. All programs should use strsignal instead.
Issue explanation at greenbone/gvmd#1279, based off fix at greenbone/gvmd#1280.
Required to work with glibc >= 2.32.
https://sourceware.org/pipermail/libc-announce/2020/000029.html
The deprecated arrays sys_siglist, _sys_siglist, and sys_sigabbrev
are no longer available to newly linked binaries, and their declarations
have been removed from <string.h>. They are exported solely as
compatibility symbols to support old binaries. All programs should use
strsignal instead.
What: N/A
Why: #1279
How: N/A
Checklist: