Remove bid and bugtraq_id handling #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaterkamp
changed the title
swaterkamp
force-pushed
the
swaterkamp/removeBID2110
branch
from
cd42859 to
849d78b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3122 +/- ##
==========================================
- Coverage 57.74% 57.73% -0.01%
==========================================
Files 1037 1037
Lines 25098 25093 -5
Branches 7185 7181 -4
==========================================
- Hits 14492 14487 -5
Misses 9604 9604
Partials 1002 1002
Continue to review full report at Codecov.
|
sarahd93
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove bid and bugtraq_id handling
Why:
This "feature" is no longer supported
How:
BID refs were not listed on the detailspages (nvt, result) anymore anyway, because of greenbone/openvas-scanner#724 So removing the code and updatng the tests was everything that needed to be done.
Checklist: