ignore script_bugtraq_id() and warn in linter #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The nasl-function script_bugtraq_id() is now getting ignored. The linter warns if it is used.
Why:
As securityfocus.com has lost it's value / importance these days it doesn't make much sense to have a dedicated script tag just for this page which isn't a clickable link anyway. In addition users probably don't know what the "BID" in the reference is as well.
How:
Changed the pointer to the script_bugtraq_id() function to a dummy function which does nothing, so it skips it. Added a warning for the linter in case the function appears. Tested it with a custom script which contains the function. For openvas-nasl nothing happened and for openvas-nasl-linter a warning was shown on the command line.
Checklist: