Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix handling of missing delta result fields #3905

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

timopollmeier
Copy link
Member

What

The delta icons for severity, QoD and hostname now handle missing values for the delta result correctly.

The delta icons for severity, QoD and hostname now handle missing values
for the delta result correctly.
@timopollmeier timopollmeier requested a review from a team as a code owner October 24, 2023 13:48
@timopollmeier timopollmeier added the patch release Create a new patch release label Oct 24, 2023
@github-actions
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #3905 (a51b65f) into main (d7ec5c7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3905      +/-   ##
==========================================
- Coverage   59.92%   59.92%   -0.01%     
==========================================
  Files        1022     1022              
  Lines       25113    25112       -1     
  Branches     7437     7436       -1     
==========================================
- Hits        15049    15048       -1     
  Misses       9116     9116              
  Partials      948      948              
Files Coverage Δ
src/web/pages/results/row.js 87.50% <100.00%> (-0.31%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@a-h-abdelsalam a-h-abdelsalam merged commit 56aecc3 into main Oct 25, 2023
13 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the fix-missing-delta-result-handling branch October 25, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Create a new patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants