Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_simult_ips_same_host field for targets #1346

Merged

Conversation

timopollmeier
Copy link
Member

What:
This adds the allow_simult_ips_same_host column to the targets and corresponding elements to the GMP commands create_target, get_targets and modify_target.
The value is sent to the scanner as a scanner preference.

Why:
This allows defining the scanner preference added in greenbone/openvas-scanner#604 as part of the target in case scanning multiple IP addresses of a single host causes problem

How:
I've checked the GMP responses of the get_targets command by inspecting the HTTP responses for the targets list and trashcan in GSA.

For the other two GMP commands I've used gvm-cli with GMP commands like the following with the values "0", "1" and "123":

<modify_target target_id="88c4b9e5-5b1c-4a0b-8b7c-b2b098676526">
  <allow_simult_ips_same_host>0</allow_simult_ips_same_host>
</modify_target>
<create_target>
  <allow_simult_ips_same_host>0</allow_simult_ips_same_host>
  <name>localhost test</name>
  <hosts>localhost</hosts>
  <port_list id="c7e03b6c-3bbe-11e1-a057-406186ea4fc5"/>
</create_target>

Checklist:

This new flag will allow setting whether multiple IPs of the same host
can be scanned simultaneously.
This adds a new element for the option to the response.
The new column is now copied as well when a target is cloned.
When moving targets to the trashcan or restoring them, the new column is
now also copied.
When preparing a scan with task_scanner_options, add the target option
allow_simult_ips_same_host to the list of scanner preferences.
@timopollmeier timopollmeier marked this pull request as ready for review November 4, 2020 16:29
src/manage_sql.c Show resolved Hide resolved
@timopollmeier timopollmeier merged commit 9f3321d into greenbone:master Nov 5, 2020
@timopollmeier
Copy link
Member Author

Note: The field has been renamed to allow_simultaneous_ips in #1396

@timopollmeier timopollmeier deleted the allow_simult_ips_same_host branch October 15, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants