Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and fix preference allow_simultaneous_ips #1396

Merged

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Jan 22, 2021

What:

The target field and scanner preference allow_simult_ips_same_host is
renamed to allow_simultaneous_ips.
Also, sending the preference now uses the correct name and missing GMP
documentation for create_target has been added.

Why:
The field and preference were renamed to avoid abbreviations while also
shortening it a bit.

How did you test it:

  • Checking the field in the GSA HTTP responses
  • Using an updated python-gvm to create and modify targets

Checklist:

The target field and scanner preference allow_simult_ips_same_host is
renamed to allow_simultaneous_ips to avoid abbreviations.
Also, sending the preference now uses the correct name and missing GMP
documentation for create_target has been added.
@timopollmeier timopollmeier force-pushed the rename-allow_simult_ips_same_host branch from 2b664a7 to dfb3309 Compare January 22, 2021 15:04
@timopollmeier timopollmeier marked this pull request as ready for review January 22, 2021 15:04
@mattmundell mattmundell merged commit 8c41bba into greenbone:master Jan 25, 2021
@timopollmeier timopollmeier deleted the rename-allow_simult_ips_same_host branch October 15, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants