Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CERT and SCAP back to using CVSS instead of integer scores #1476

Merged

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Apr 7, 2021

What:
The 0 - 100 integer score element is replaced with a CVSS severity
one as gvmd will continue using the previous severity scoring system.
This still changes the name of the element in SCAP and CERT info
compared to 20.08 to make the element names more consistent.

Why:
The new integer scores were not applied consistently and it's simpler to revert to the previous scoring system than to adjust to the new one for the upcoming release.

How did you test it:
By checking the non-severity fields in the list and details pages in GSA and the severity field in the XML responses.

Checklist:

The 0 - 100 integer `score` element is replaced with a CVSS `severity`
one as gvmd will continue using the previous severity scoring system.
This still changes the name of the element compared to 20.08 to make the
element names more consistent.
@timopollmeier timopollmeier force-pushed the revert-integer-scores branch from 24f2df8 to 7230380 Compare April 7, 2021 13:02
@timopollmeier timopollmeier marked this pull request as ready for review April 8, 2021 07:14
@timopollmeier timopollmeier requested a review from a team as a code owner April 8, 2021 07:14
@timopollmeier timopollmeier changed the title Change gvmd back to using CVSS instead of integer scores Change CERT and SCAP back to using CVSS instead of integer scores Apr 8, 2021
@timopollmeier timopollmeier added the backport-to-main This pull request will be ported to the master branch label Apr 8, 2021
The function was still trying to use the score column that was replaced
by severity.
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions to clarify. Additionally I am not sure about migrations at all. Do we need some? Are they going to be implemented in another PR?

src/gmp.c Show resolved Hide resolved
src/gmp.c Show resolved Hide resolved
src/manage_pg.c Show resolved Hide resolved
src/manage_pg.c Show resolved Hide resolved
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Timo!

@bjoernricks bjoernricks merged commit db55d6b into greenbone:gvmd-21.04 Apr 8, 2021
@timopollmeier timopollmeier deleted the revert-integer-scores branch October 15, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-main This pull request will be ported to the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants