Use CVSS severity in NVTs, vulns and results again #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 0 - 100 integer `score` element is replaced with a CVSS `severity` one as gvmd will continue using the previous severity scoring system. This still changes the name of the element compared to 20.08 to make the element names more consistent.
The function was still trying to use the score column that was replaced by severity.
The integer score elements have been removed and the new severities element in NVTs now uses the CVSS scale for scores.
The make_cve_result function still contained parts of SQL for the now removed score column and init_host_prognosis_iterator was using the wrong column name for the severity.
2 tasks
timopollmeier
added
the
backport-to-main
bjoernricks
approved these changes
Apr 9, 2021
timopollmeier
added a commit
that referenced
this pull request
Apr 9, 2021
Use CVSS severity in NVTs, vulns and results again (bp #1477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The integer score elements have been removed and the new severities
element in NVTs now uses the CVSS scale for scores.
An SQL error introduced with renaming the SecInfo severity columns has
also been fixed.
(Requires greenbone/gvm-libs#472 and #1476)
Why:
To keep the severity scores consistent while not having to update the scoring elsewhere
shortly before the release.
How did you test it:
Checklist: