Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the special default for details from GET_REPORTS #747

Merged
merged 7 commits into from
Sep 16, 2019
Merged

Remove the special default for details from GET_REPORTS #747

merged 7 commits into from
Sep 16, 2019

Conversation

mattmundell
Copy link
Contributor

Checklist:

@mattmundell mattmundell marked this pull request as ready for review September 11, 2019 12:50
timopollmeier
timopollmeier requested changes Sep 12, 2019
View reviewed changes
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in gmp.c works for me but there is a small mistake in the GMP doc and one part that I think doesn't have to be changed even if I don't see any immediate effect.

src/schema_formats/XML/GMP.xml.in Show resolved Hide resolved
src/gmp.c Show resolved Hide resolved
@timopollmeier timopollmeier merged commit 014781a into greenbone:master Sep 16, 2019
@mattmundell mattmundell deleted the details-default branch September 16, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

@bjoernricks bjoernricks Awaiting requested review from bjoernricks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @timopollmeier