Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the special default for details from GET_REPORTS #747

Merged
merged 7 commits into from
Sep 16, 2019
Merged

Remove the special default for details from GET_REPORTS #747

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9eee66a
Remove the special default for details from GET_REPORTS
mattmundell Sep 11, 2019
8f8626a
Update changelog
mattmundell Sep 11, 2019
033819c
Add CHANGE doc for default change
mattmundell Sep 11, 2019
7d7aff0
Merge branch 'master' into details-default
timopollmeier Sep 12, 2019
18f6ba0
Fix CHANGE doc
mattmundell Sep 13, 2019
0094c5a
Merge branch 'master' into details-default
mattmundell Sep 16, 2019
7d48548
Merge branch 'master' into details-default
timopollmeier Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Send delete command to ospd after stopping the task. [#710](https://github.com/greenbone/gvmd/pull/710)
- Check whether hosts are alive and have results when adding them in slave scans. [#717](https://github.com/greenbone/gvmd/pull/717) [#736](https://github.com/greenbone/gvmd/pull/736)
- New columns Ports, Apps, Distance, and Auth in the CSV Hosts report format [#733](https://github.com/greenbone/gvmd/pull/733)
- The details attribute of GET_REPORTS now defaults to 0 [#747](https://github.com/greenbone/gvmd/pull/747)

### Fixed
- A PostgreSQL statement order issue [#611](https://github.com/greenbone/gvmd/issues/611) has been addressed [#642](https://github.com/greenbone/gvmd/pull/642)
Expand Down
10 changes: 0 additions & 10 deletions src/gmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6273,16 +6273,6 @@ gmp_xml_handle_start_element (/* unused */ GMarkupParseContext* context,
attribute_names,
attribute_values);

/* Special case details with default 1, for backward
* compatibility. */
if (find_attribute (attribute_names, attribute_values,
"details", &attribute))
get_reports_data->report_get.details = strcmp (attribute, "0");
else
get_reports_data->report_get.details = 1;
get_reports_data->get.details
timopollmeier marked this conversation as resolved.
Show resolved Hide resolved
= get_reports_data->report_get.details;

g_free (get_reports_data->report_get.filt_id);
get_reports_data->report_get.filt_id = NULL;
append_attribute (attribute_names, attribute_values,
Expand Down
11 changes: 11 additions & 0 deletions src/schema_formats/XML/GMP.xml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27175,6 +27175,17 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.

<!-- Compatibility changes between versions. -->

<change>
<command>GET_REPORTS</command>
<summary>Default of "details" attribute is now 0</summary>
<description>
<p>
The default of the "details" attribute has changed from 1 to 0.
This matches the defaults of all the other GET commands.
</p>
</description>
<version>9.0</version>
</change>
timopollmeier marked this conversation as resolved.
Show resolved Hide resolved
<change>
<command>GET_REPORTS</command>
<summary>Remove report type "assets"</summary>
Expand Down