-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third section of methylation #955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of feedback. Can you take a look through and merge what you agree with and see if there are additional changes that you want to make? There needs to be a little bit more detail on the other VAE paper too, and ideally some synthesis of the results. If that paragraph gets too long, it may be good to split to VAE / non-VAE. In that case, it may not make sense to move the sentence that I noted.
content/04.study.md
Outdated
@@ -47,6 +47,26 @@ Deep learning applied to gene expression data is still in its infancy, but the f | |||
Many previously untestable hypotheses can now be interrogated as deep learning enables analysis of increasing amounts of data generated by new technologies. | |||
For example, the effects of cellular heterogeneity on basic biology and disease etiology can now be explored by single-cell RNA-seq and high-throughput fluorescence-based imaging, techniques we discuss below that will benefit immensely from deep learning approaches. | |||
|
|||
### DNA Methylation (to remove after merge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this will cause merge conflicts, so noting here that we should merge this last.
Updates based on pull-request peer-review. Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two one sentence per line changes
Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more things for clarity and then I'll handle the merge conflict and put this in.
Additional clarity Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com>
Updates based on peer-review Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the versioned DOI breaks the build. Trying without the v
resolve citation error Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com>
All checks passed. |
This build is based on f000c4c. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/deep-review/builds/562448060 https://travis-ci.org/greenelab/deep-review/jobs/562448061 [ci skip] The full commit message that triggered this build is copied below: Third section of methylation (#955) * Update 04.study.md * Apply suggestions from code review Updates based on pull-request peer-review. Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com> * Update 04.study.md * Apply suggestions from code review Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com> * Update content/04.study.md Additional clarity Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com> * Apply suggestions from code review Updates based on peer-review Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com> * Update content/04.study.md resolve citation error Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com>
This build is based on f000c4c. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/deep-review/builds/562448060 https://travis-ci.org/greenelab/deep-review/jobs/562448061 [ci skip] The full commit message that triggered this build is copied below: Third section of methylation (#955) * Update 04.study.md * Apply suggestions from code review Updates based on pull-request peer-review. Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com> * Update 04.study.md * Apply suggestions from code review Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com> * Update content/04.study.md Additional clarity Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com> * Apply suggestions from code review Updates based on peer-review Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com> * Update content/04.study.md resolve citation error Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com>
This is the 3 of 3 for sections of the methylation section addition to the Deep Review.