Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread methylation sections #971

Merged
merged 6 commits into from
Jul 29, 2019

Conversation

agitter
Copy link
Collaborator

@agitter agitter commented Jul 27, 2019

This follows up on #954 and #955. In some cases the original meaning wasn't clear to me, for instance

uncovered from datasets with more noise, such as solid tissue samples over blood samples

@jlevy44 and @AlexanderTitus please double check that I didn't alter the meaning.

@agitter agitter requested a review from cgreene July 27, 2019 13:14
Copy link
Contributor

@jlevy44 jlevy44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just thought I'd amend some changes I made earlier. I realized that I had wrongly grouped DAPL with other methods that look at sequence and topology, so I moved the paper to later in the text.

content/04.study.md Outdated Show resolved Hide resolved
content/04.study.md Outdated Show resolved Hide resolved
Copy link
Member

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending changes from @jlevy44 being included. Please feel free to merge afterwards

agitter and others added 5 commits July 28, 2019 14:53
Co-Authored-By: Joshua Levy <joshualevy44@berkeley.edu>
Co-Authored-By: Joshua Levy <joshualevy44@berkeley.edu>
@agitter agitter merged commit f441693 into greenelab:master Jul 29, 2019
@agitter agitter deleted the proofread-methylation branch July 29, 2019 11:09
dhimmel pushed a commit that referenced this pull request Jul 29, 2019
This build is based on
f441693.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/deep-review/builds/564923448
https://travis-ci.org/greenelab/deep-review/jobs/564923449

[ci skip]

The full commit message that triggered this build is copied below:

Proofread methylation sections (#971)

* Proofread methylation sections

* Update content/04.study.md

Co-Authored-By: Joshua Levy <joshualevy44@berkeley.edu>

* Update content/04.study.md

Co-Authored-By: Joshua Levy <joshualevy44@berkeley.edu>

* Move DAPL reference

* Trim whitespace

Co-Authored-By: Joshua Levy <joshualevy44@berkeley.edu>
dhimmel pushed a commit that referenced this pull request Jul 29, 2019
This build is based on
f441693.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/deep-review/builds/564923448
https://travis-ci.org/greenelab/deep-review/jobs/564923449

[ci skip]

The full commit message that triggered this build is copied below:

Proofread methylation sections (#971)

* Proofread methylation sections

* Update content/04.study.md

Co-Authored-By: Joshua Levy <joshualevy44@berkeley.edu>

* Update content/04.study.md

Co-Authored-By: Joshua Levy <joshualevy44@berkeley.edu>

* Move DAPL reference

* Trim whitespace

Co-Authored-By: Joshua Levy <joshualevy44@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants