Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize author order on CI builds #997

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

dhimmel
Copy link
Collaborator

@dhimmel dhimmel commented Mar 6, 2020

See discussion in manubot/manubot#214

uses commit hash as random seed

@AppVeyorBot
Copy link

AppVeyor build 1.0.50 for commit 6fed939 by @dhimmel is now complete. The rendered manuscript from this build is temporarily available for download at:

@dhimmel
Copy link
Collaborator Author

dhimmel commented Mar 6, 2020

--only-on-ci didn't work on GitHub. Will look into.

@AppVeyorBot
Copy link

AppVeyor build 1.0.51 for commit 2834bd6 by @dhimmel is now complete. The rendered manuscript from this build is temporarily available for download at:

@dhimmel
Copy link
Collaborator Author

dhimmel commented Mar 6, 2020

talked with @cgreene and the current implementation is not exactly what is desired. The goal is to fix the order of the v1 authors and only shuffle the order of v2 authors.

Do we want v1 authors to appear individually in the metadata and author list? Or instead do we want to condense them all into an entity like "Deep Review v1 Authors"?

I think probably we should just hardcode / copy the rendered output as the v1 authors, since this is no longer something dynamic.

@cgreene
Copy link
Member

cgreene commented Mar 10, 2020

I have hardcoded the v1 authors in #998. I think I need to merge this and then test that one. Will do that now.

@cgreene cgreene merged commit 3fe0cb0 into greenelab:master Mar 10, 2020
@dhimmel dhimmel deleted the randomize-author-order branch March 10, 2020 13:49
dhimmel added a commit that referenced this pull request Mar 10, 2020
merges #998
follows up #997

Co-authored-by: Daniel Himmelstein <daniel.himmelstein@gmail.com>
@cgreene cgreene mentioned this pull request Mar 10, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants