Hardcode v1 authors and remove them from metadata #998
Conversation
|
AppVeyor build 1.0.55 for commit 77a8da6 by @cgreene is now complete. The rendered manuscript from this build is temporarily available for download at: |
|
Ok - I'm pretty sure this will work now. |
|
AppVeyor build 1.0.57 for commit 8cd7707 by @cgreene is now complete. The rendered manuscript from this build is temporarily available for download at: |
|
This doesn't contain the work from #997 yet, but that is OKAY. these two PRs can be merged independently. I wonder if we should delete the v1 authors in metadata or move them to a field like Looks like the newlines between affiliations have been removed. maybe because no longer a numbered list? |
|
Ahh! I was wondering what happened with those newlines. You're right - making the affiliations have a version prefix broke the numbered list. I could make a bulleted list with the numbers after them, add an additional line (though that'd make a paragraph space), or something else. What do you think? |
|
Just read about pandoc's
The easiest solution at the moment would be to add |
|
I had no idea that was possible! |
|
AppVeyor build 1.0.58 for commit 38c2e9d by @cgreene is now complete. The rendered manuscript from this build is temporarily available for download at: |
|
AppVeyor build 1.0.59 for commit 031daee by @cgreene is now complete. The rendered manuscript from this build is temporarily available for download at: |
Co-Authored-By: Daniel Himmelstein <daniel.himmelstein@gmail.com>
|
AppVeyor build 1.0.60 for commit ca18e93 by @cgreene is now complete. The rendered manuscript from this build is temporarily available for download at: |
|
AppVeyor build 1.0.61 for commit cb20daa by @dhimmel is now complete. The rendered manuscript from this build is temporarily available for download at: |
|
AppVeyor build 1.0.62 for commit 6cb5767 by @dhimmel is now complete. The rendered manuscript from this build is temporarily available for download at: |
dhimmel
changed the title
|
AppVeyor build 1.0.63 for commit c4daec3 by @dhimmel is now complete. The rendered manuscript from this build is temporarily available for download at: |
[ci skip] This build is based on a1e4457. This commit was created by the following CI build and job: https://github.com/greenelab/deep-review/commit/a1e44575bada6295dc253f9d53680dd21555effa/checks https://github.com/greenelab/deep-review/runs/53044533
[ci skip] This build is based on a1e4457. This commit was created by the following CI build and job: https://github.com/greenelab/deep-review/commit/a1e44575bada6295dc253f9d53680dd21555effa/checks https://github.com/greenelab/deep-review/runs/53044533
|
What do we want to happen for an author who contributes to v1 and v2 and has a change in competing interests? Do we keep the old date and old COI in the v1 table but use the newer date and current COI in the v2 table? |
|
@agitter : Not ideal, but that was the only thing I could come up with, unless we added a display true/false flag and kept the old author metadata. |
|
Yeah, I don't have a great way to improve upon the current approach. When version 2.0 is close to finished, we could always manually update entries in the version 1.0 COI table. |
I tried to pull from @dhimmel's branch associated with #997, make some more updates to better address the complexities, and then push back but I think I must have pushed to the wrong place.