System gcc fixes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a compiler with a spec file that conditionally includes it's own
linker script broke linking:
/usr/lib/riscv64-unknown-elf/bin/ld:../../../../sw/ld/linker.ld:29: nonconstant expression for load base
collect2: error: ld returned 1 exit status
It appears something in the generic riscv linker script that picolibc
ships (/usr/lib/picolibc/riscv64-unknown-elf/lib/picolibc.ld) is
conflicting with our customer linker script.
The link section of the spec file has this:
%{!T:-Tpicolibc.ld}
So if we pass `-T` to GCC instead of `-Wl,--script`, the compiler will
use our linker script over the spec file.
Signed-off-by: Joel Stanley <joel@jms.id.au>
The riscv64-unknown-elf toolchain is (can be?) the system installed
riscv compiler. On Debian (and Ubuntu?) this does not default to a libc;
you must specify the spec file to use. Without doing this the build
fails:
make: Entering directory '/home/joel/dev/fpgas/oc/foboot/hw/build/software/bios'
CC ../../../../sw/src/dfu.c dfu.o
../../../../sw/src/dfu.c:25:10: fatal error: string.h: No such file or directory
#include <string.h>
^~~~~~~~~~
As Debian ships a riscv picolibc package, use this.
Signed-off-by: Joel Stanley <joel@jms.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows me to use the riscv toolchain and riscv picolibc shipped by Debian. I tested with the version in testing (1.7.4-1 for picolibc).
This assumes the user has the picolibc package installed if the compiler is riscv64-unknown-elf. That may not be always true, so I am open to alternate suggestions.