Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leiningen 2.9.0 & whidbey 2.1.0 adding newline to output? #30

Closed
drbobbeaty opened this issue Mar 2, 2019 · 2 comments
Closed

Leiningen 2.9.0 & whidbey 2.1.0 adding newline to output? #30

drbobbeaty opened this issue Mar 2, 2019 · 2 comments
Assignees
Labels

Comments

@drbobbeaty
Copy link

I just updated to Leiningen 2.9.0 and tried whidbey 2.1.0 and the result was that extra newlines are being added to the output:
2019-03-02 at 7 41 am
If I go back to Leiningen 2.8.3 the extra newlines aren't there. Same whidbey version.

Is there something about whidbey that can be configured for the change in nREPL?

@drbobbeaty drbobbeaty changed the title whidbey 2.1.0 adding newline to output? Leiningen 2.9.0 & whidbey 2.1.0 adding newline to output? Mar 2, 2019
@greglook greglook self-assigned this Mar 4, 2019
@greglook
Copy link
Owner

greglook commented Mar 4, 2019

This is an unfortunate side-effect of the new approach to print IO in nrepl. Previously, whidbey would use puget to fully render the result as a string (without a newline) and then send it to the client. Now, output is streamed to the repl client, and this doesn't give whidbey an opportunity to trim the trailing newline. See #28 for some more context.

In the future this could be fixed in a couple of ways, but for now there's no easy workaround.

@drbobbeaty
Copy link
Author

Thank you so much for a good description of the issue. I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants