Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to nrepl 0.6.0 and whidbey 2.0.0 #101

Closed

Conversation

johannesloetzsch
Copy link

@johannesloetzsch johannesloetzsch commented Feb 23, 2019

@venantius
Copy link
Owner

I think this may need to be rebased onto master?

@johannesloetzsch
Copy link
Author

I think this may need to be rebased onto master?

I merged upgrade-nrepl into master before I did the changes. The branch of the pull request is now 2 commits ahead of master, so I think no rebase is needed.

If you are willing to use this as the new master, feel free to squash the changes.

@johannesloetzsch
Copy link
Author

This branch works well with the new released [mvxcvi/whidbey "2.1.0"].

I would appreciate, if you could test it, give feedback and eventually (squash+)merge it.

@venantius
Copy link
Owner

Hey - I'm sorry for the delay in getting back to you on this.

Thank you for the work you've put in here - I've noticed you also helping out other people upstream. I've been working on this problem in a branch of my own and will be merging that. At the moment I've got everything in a workable state but the perfectionist in me is a little irked about the one remaining change in behavior that I don't love, which is this.

I'm going to push my changes up for now and merge into master, but I'm going to wait a few days to cut a release to see if the newline issue gets resolved before then.

@venantius venantius closed this Mar 4, 2019
@johannesloetzsch
Copy link
Author

ok, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants