-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring TableFooter #1349
Refactoring TableFooter #1349
Conversation
@@ -1,9 +1,7 @@ | |||
import React from 'react'; | |||
import { spy, stub } from 'sinon'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary codes
@wdh2100 Can you verify that you ran "npm run test"? I had some issues but realized it they were already in the v3.1.0 branch (so not related to you). It's kind of late, so I'm thinking of saving the rest of these for next week's release. However, looks like I can't test from codesandbox so figured I'd ask before doing the merge. |
but mocha.opts <--- deprecated ref : https://github.com/mochajs/mocha/releases/tag/v8.0.0 |
Rebase v3.2.0 |
Thank you for adding the tests. I have a footer feature I want to add for version 3.2.0. I'm going to merge this branch into the jumpToPage branch and work on it there. |
thanks! |
Refactor from class component to functional component
ref : #1346
Sorry. When I split it in PR, it's lot..
codeSandBox : http://codesandbox.io/s/github/wdh2100/mui-datatables/tree/functional/tableFooter