-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mui-datatables v3.2.0 #1404
mui-datatables v3.2.0 #1404
Conversation
Refactoring TableFooter
Refactoring TableSearch and TableViewCol
Added setFilterChipProps
Refactored out unsafe_componentWillMount
Added jumpToPage option
Added TableViewCol and Checkbox to components property (so that custom versions can be inputted)
@@ -1,9 +1,14 @@ | |||
import Chip from '@material-ui/core/Chip'; | |||
import PropTypes from 'prop-types'; | |||
import React from 'react'; | |||
import classnames from 'classnames'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you accept a PR to replace classnames
with clsx
? Only suggesting because I learned today that @material-ui/core
uses clsx
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just finished looking into it (mui/material-ui#14152). Smaller, faster, same API, and Material UI switched from classnames to clsx. I'd would accept a PR for this change.
Replace classnames with clsx in example
Branch for the 3.2.0 release of mui-datatables. It contains the following:
A beta version is available via:
Currently a work in progress, will probably be released next week.