Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctan #260

Merged
merged 3 commits into from
Aug 22, 2016
Merged

Ctan #260

merged 3 commits into from
Aug 22, 2016

Conversation

rpspringuel
Copy link
Contributor

Corresponds to gregorio-project/gregorio#1210

Note: I'm still double checking these test results against TL2015. With these changes we have a full pass on (updated) TL2016.

@rpspringuel
Copy link
Contributor Author

I've checked backwards compatibility of the tests and I get no failures with TL2015 and only one with TL2014. Interestingly, the TL2014 failure isn't one of the previously known failures. Both of those pass, but the double-clef test fails (though along the same lines as the previously known failures: in the line breaking choices). Should I edit the README to note the change in known failures?

@henryso
Copy link
Contributor

henryso commented Aug 20, 2016

I suppose we have three options:

  1. Say that this version of Gregorio requires TeX Live 2015, or
  2. Say that double clefs are only supported from TeX Live 2015
  3. Try to fix the problem in TeX Live 2014.

@eroux
Copy link
Contributor

eroux commented Aug 20, 2016

I would be in favor of option 1...

@rpspringuel
Copy link
Contributor Author

Well, it's not that the double clefs don't work with TL2014, it simply that the line breaking decisions in TL2014 are slightly different and this results in the test failing. We had this same problem with two other tests before (clef_change and fix-508), but those differences seem to have gone away now (probably due to some space tuning somewhere that results in the line break decision being more "obvious"). My inclination is simply to update the list of known failures in TL2014 (in README.md). It's only those running the tests that will likely really worry about this.

@henryso
Copy link
Contributor

henryso commented Aug 20, 2016

In that case, I would just note that line breaking decisions are different in TeX Live 2014 and leave it at that.

@rpspringuel rpspringuel merged commit c4ed261 into gregorio-project:master Aug 22, 2016
@rpspringuel rpspringuel deleted the ctan branch September 24, 2016 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants