-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cheating horizontal episemus height #872
Comments
How about just |
Hmm this seems a bit too generic, who knows what other |
Well, we could delimit elements that would extend the "look around" when determining glyph height extrema, as in |
Oh, that's a good idea! A bit more difficult to explain, but certainly better once understood. How do you think you would deal with the centering of the episemus (not shifted lower no higher than the middle)? We can implement it later, but maybe it's best to know how it will be noted in gabc? |
I'll admit I don't understand "not shifted lower no higher than the middle"? |
In the first picture, the episemus on gis is not right in the middle of the line, it's slightly lower, and the episemus on ter is not in the middle of the line, it's slightly higher. The idea would be to make them both on the middle, for balance. |
That would make things pretty complicated, as the heights of the horizontal episemata are current fixed to a pitch (+ above vs. below), and this would be between pitches. Let me think more about the notations. Do you have anything to suggest? |
precisely... so maybe |
I think it might be better to allow the episema to be nudged by specifying a dimension: |
That seems good, though I think the value should be scaled by |
|
Hmm, I think I see better what you mean now, sorry, I think my question was kind of stupid... let's just detail the algorithm a bit. in the case |
Not exactly.
What you probably want for your case is
Does that make clear what I'm suggesting? |
Ok, but it means that the problem is not solved... the idea in the |
Ah, now I understand why you were saying there are complex edge cases, which is very true... and I don't know how to deal with it properly. |
Thinking back about it, the |
Or maybe better, have a
? |
I will implement
How does that sound? |
That's a bit complex, but it provides all fine tuning possibilities users might want, now and in the future, so I think it's perfect! |
Unless it really screws up the parser, I wouldn't prohibit the |
Ok. |
The position in the space is different depending on whether the episema is above the note or below it, so even using this new feature, in the Thoughts? |
How many kinds of positions are there? I thought there was:
or are these four different? |
Those are the four cases, and all have different offsets. |
Ok I see... not counting the offsets for very high or very low notes... Well, why not
? Or maybe |
Ok, that sounds doable. Although I was using |
Sorry yes, use |
(what I mean by new height is: no need to compute the exact middle by computing the height of the episemus, etc.) |
Should I make the other four offsets tunable via dimensions? If so, what in the world should I call them that would make sense to a user? |
How incredible, I really couldn't believe my eyes when I saw they were not in gsp-default already... So yes, definitely! Maybe |
(oh, and vertical episemus and punctum mora shifts should be tunable too!) |
Would it be better to draw the horizontal episema in the font such that it is centered correctly so that these offsets need not be tuned per font? |
that makes perfect sense indeed! |
If it helps, I can change the font to make the horizontal episemus centered in height and also make the spacings tunable, tell me |
I am in the code that does the shifting, so if you could make the font changes and let me know what the new shift values should be for the 5 cases, I can take care of putting it into gsp-default and getting the glyphraise calculation macro working. |
I'm also considering the following:
|
You can shift them all by |
The new syntax looks good! Where should I push the change in the fonts? |
a new branch in the main repository is perfect. |
Sorry, it's |
done |
Thanks. It will take me a few hours tonight to make these changes, so I should have something tomorrow. |
Perfect, thanks a lot! |
Made all distances used in glyph raise calculation tunable. Restored scandicus determination. Fixes gregorio-project#872 and gregorio-project#897.
…miktex * commit 'aede743be1944f99fdd26bfe7301d0daa7336168': Implemented horizontal episema position tuning. Made all distances used in glyph raise calculation tunable. Restored scandicus determination. Fixes gregorio-project#872 and gregorio-project#897. consonnant -> consonant improve lyric centering documentation center horizontal episemus vertically
…bar_spacing * commit '1fd9f6e8aff035baa54ce706fd996a543989617a': (27 commits) Implemented horizontal episema position tuning. Made all distances used in glyph raise calculation tunable. Restored scandicus determination. Fixes gregorio-project#872 and gregorio-project#897. consonnant -> consonant improve lyric centering documentation center horizontal episemus vertically Forgot the option which indicates what luaotfload-tool is supposed to do Missing file in fonts manifest Forgot to rename system-setup.sh in manifest Minor fixes Update version number Excluding non-Windows files from contrib Adjusting file manifests Better description. Documentation Overhead to make system-setup.command behave better when double-clicked Typo Resyncing version numbers for previously unversioned files. Debug message command needs to appear after it is defined. Reorder file list in system-setup scripts Missing file from Windows install inventory Updates to system-setup scripts ...
…bar_spacing * commit 'd2ab44758dc5d9713b3c2f3369f8aea5e58095e9': Added/updated tests for horizontal episema tuning and scandicus determination. Tests gregorio-project/gregorio#872 and gregorio-project/gregorio#897.
Updated horizontal episema adjustment parse comment (again) from #872.
In the following example:
it would be important to be able to make the second set of horizontal episemus (on ter) be on the exact same height as the one before (gis). I think detecting this automatically is just too complex, so I propose a notation to be able to "cheat" horizontal episemus placing. For example here
ter(ixg[hh:f]hi)
would make the horizontal episemus placing algorithm think the first note is anf
and thus place the whole episemus on the correct position... What do you think?The text was updated successfully, but these errors were encountered: