Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquescent scandicus determination is broken #897

Closed
henryso opened this issue Feb 10, 2016 · 2 comments
Closed

Liquescent scandicus determination is broken #897

henryso opened this issue Feb 10, 2016 · 2 comments
Assignees
@henryso
Labels
bug C question
Milestone
4.1

Comments

@henryso
Copy link
Contributor

henryso commented Feb 10, 2016

Attempting to create a liquescent scandicus in gregorio 4.1-beta2 will fail with an assertion error. This is due to an error in the assertion.
@henryso henryso self-assigned this Feb 10, 2016
@henryso henryso added this to the 4.1 milestone Feb 10, 2016
@henryso
Copy link
Contributor Author

henryso commented Feb 10, 2016

In adding the assertions, I asserted that liquescent scandicus would be determined properly in glyph determination; it is not and (in the prior code) resulted in a fall back to three individual notes glued together. There are three ways I can see to fix this:

  • remove the assertion and restore this figure falling back to being three notes glued together
  • determine it as something else (punctum + podatus, podatus + punctum?)
  • draw the missing glyphs and determine it as liquescent scandicus.

Any thoughts or suggestions?

@eroux
Copy link
Contributor

eroux commented Feb 10, 2016

What comes to my mind first is the first solution... let's wait for a user request before implementing the third one. About two, I'm pretty sure I've seen figures like (ghi<) somewhere, so let's not do it...

henryso added a commit to henryso/gregorio-test that referenced this issue Feb 10, 2016
@henryso
Added/updated tests for horizontal episema tuning and scandicus deter…
e78efcc 
…mination.

Tests gregorio-project/gregorio#872 and gregorio-project/gregorio#897.
henryso added a commit to henryso/gregorio that referenced this issue Feb 10, 2016
@henryso
Implemented horizontal episema position tuning.
337e20c 
Made all distances used in glyph raise calculation tunable.
Restored scandicus determination.
Fixes gregorio-project#872 and gregorio-project#897.
This was referenced Feb 10, 2016
Merged
Merged
@henryso henryso closed this as completed Feb 10, 2016
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Feb 11, 2016
@rpspringuel
Merge commit 'aede743be1944f99fdd26bfe7301d0daa7336168' into feature/…
e4f66de 
…miktex

* commit 'aede743be1944f99fdd26bfe7301d0daa7336168':
  Implemented horizontal episema position tuning. Made all distances used in glyph raise calculation tunable. Restored scandicus determination. Fixes gregorio-project#872 and gregorio-project#897.
  consonnant -> consonant
  improve lyric centering documentation
  center horizontal episemus vertically
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Feb 11, 2016
@rpspringuel
Merge commit '1fd9f6e8aff035baa54ce706fd996a543989617a' into feature/…
235aefb 
…bar_spacing

* commit '1fd9f6e8aff035baa54ce706fd996a543989617a': (27 commits)
  Implemented horizontal episema position tuning. Made all distances used in glyph raise calculation tunable. Restored scandicus determination. Fixes gregorio-project#872 and gregorio-project#897.
  consonnant -> consonant
  improve lyric centering documentation
  center horizontal episemus vertically
  Forgot the option which indicates what luaotfload-tool is supposed to do
  Missing file in fonts manifest
  Forgot to rename system-setup.sh in manifest
  Minor fixes
  Update version number
  Excluding non-Windows files from contrib
  Adjusting file manifests
  Better description.
  Documentation
  Overhead to make system-setup.command behave better when double-clicked
  Typo
  Resyncing version numbers for previously unversioned files.
  Debug message command needs to appear after it is defined.
  Reorder file list in system-setup scripts
  Missing file from Windows install inventory
  Updates to system-setup scripts
  ...
rpspringuel added a commit to rpspringuel/gregorio-test that referenced this issue Feb 11, 2016
@rpspringuel
Merge commit 'd2ab44758dc5d9713b3c2f3369f8aea5e58095e9' into feature/…
c767efd 
…bar_spacing

* commit 'd2ab44758dc5d9713b3c2f3369f8aea5e58095e9':
  Added/updated tests for horizontal episema tuning and scandicus determination. Tests gregorio-project/gregorio#872 and gregorio-project/gregorio#897.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryso henryso

Labels
bug C question
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
2 participants
@eroux @henryso