gui: don't show datadir error msgbox if arg isn't specified #2617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-#2524 ReadClientStateXml only logged the failure of trying to access client_state.xml, however in that commit this behaviour was changed to create a message box. This is sub-optimal experience for new users who have not yet installed BOINC, people aiming to go Folding@Home only if the poll passes and me who does development work on a secondary device where the datadir is constantly discarded.
Also the caption is set as message boxes are shown as
{caption}: {message}
to CLI users.