gui: Fix TransactionRecord::decomposeTransaction to properly display self-sidestake #2647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR is a fix to TransactionRecord::decomposeTransaction to properly handle self-sidestaking. The staking transaction for display in the GUI is split by the decompositor into a "gross" stake transaction, then separate sidestakes to the destination addresses. In the situation where the destination sidestake is actually IN the same wallet (i.e. "IsMine"), the gross stake transaction has to be decremented by the value of these self-stakes, because for self-stakes the "out" stake that would normally be displayed is actually from the SAME address as the stake input.
This has to go in LaVerne.