Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveWidget() now call _triggerChangeEvent() #1147

Merged
merged 2 commits into from
Feb 16, 2020
Merged

RemoveWidget() now call _triggerChangeEvent() #1147

merged 2 commits into from
Feb 16, 2020

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Feb 16, 2020

Description

Checklist

  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* fix for #1142
* make sure to call any other change when adding/removing widgets
* this right now can call extra uncessary change CB at times, but better than not calling on nodes that changed.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 67.839% when pulling 7c9b656 on adumesny:develop into bd6910e on gridstack:develop.

@adumesny adumesny merged commit e660480 into gridstack:develop Feb 16, 2020
@adumesny adumesny mentioned this pull request Feb 16, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants