Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimized change callback #1148

Merged
merged 1 commit into from
Feb 16, 2020
Merged

optimized change callback #1148

merged 1 commit into from
Feb 16, 2020

Conversation

adumesny
Copy link
Member

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
optimized change callback
920195a 
* save original x,y,w,h values and only call those that changed
(and not just tempory flag _dirty)
* getting all the test cases was tricky. Used all demos with some mods.
* related to #1147 which fixes #1142
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 68.247% when pulling 920195a on adumesny:develop into e660480 on gridstack:develop.

@adumesny adumesny merged commit b30655d into gridstack:develop Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RemoveWidget() doesn't also trigger change events when it should
2 participants
@adumesny @coveralls