remove criteria contingencies #750
Conversation
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
src/components/dialogs/contingency-list/creation/contingency-list-creation-form.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/contingency-list/creation/contingency-list-creation-dialog.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
…nto remove-criteria-contingencies
|
| sideActionCallback: manageContingencyName, | ||
| }, | ||
| cellStyle: { padding: 0 }, | ||
| flex: 1, |
There was a problem hiding this comment.
it is useless since it is already in defaultColDef
| editable: true, | ||
| rowDrag: true, | ||
| singleClickEdit: true, | ||
| flex: 1, |
| suppressKeyboardEvent(params), | ||
| autoHeight: true, | ||
| wrapText: true, | ||
| singleClickEdit: true, |
There was a problem hiding this comment.
should be moved to defaultColDef
| field: FieldConstants.CONTINGENCY_NAME, | ||
| editable: true, | ||
| rowDrag: true, | ||
| singleClickEdit: true, |
There was a problem hiding this comment.
delete this after moving to defaultColDef
| */ | ||
|
|
||
| import { useSelector } from 'react-redux'; | ||
| import { |
There was a problem hiding this comment.
IMO you should move creation and edition dialog into explicit-naming folder
| then: (schemaThen) => schemaThen.required(), | ||
| otherwise: (schemaOtherwise) => schemaOtherwise.nullable(), | ||
| }), | ||
| [FieldConstants.EQUIPMENT_TYPE]: yup.string().nullable(), |
There was a problem hiding this comment.
Not very sure you need that!
|
|
||
| export interface ExplicitNamingEditionDialogProps { | ||
| contingencyListId: string; | ||
| contingencyListType: string; |
There was a problem hiding this comment.
you don't need that anymore since you know it is explicit naming
| const schema = yup.object().shape({ | ||
| [FieldConstants.NAME]: yup.string().trim().required('nameEmpty'), | ||
| [FieldConstants.DESCRIPTION]: yup.string().max(MAX_CHAR_DESCRIPTION), | ||
| [FieldConstants.CONTINGENCY_LIST_TYPE]: yup.string().nullable(), | ||
| [FieldConstants.EQUIPMENT_TYPE]: yup.string().when([FieldConstants.CONTINGENCY_LIST_TYPE], { | ||
| is: ContingencyListType.CRITERIA_BASED.id, | ||
| then: (schemaThen) => schemaThen.required(), | ||
| otherwise: (schemaOtherwise) => schemaOtherwise.nullable(), | ||
| }), | ||
| [FieldConstants.EQUIPMENT_TYPE]: yup.string().nullable(), | ||
| ...getExplicitNamingSchema(), | ||
| ...getCriteriaBasedSchema(), | ||
| }); | ||
|
|
||
| const emptyFormData = getContingencyListEmptyFormData(); |
There was a problem hiding this comment.
this part is almost the same as in edition dialog maybe move it to contingency-list-utils
| ...getExplicitNamingEditSchema(), | ||
| }); | ||
|
|
||
| const emptyFormData = (name?: string) => getContingencyListEmptyFormData(name); |
There was a problem hiding this comment.
i think this component is useless as the only purpose is to call another component so modify directly getContingencyListEmptyFormData. You can even rename it if you want, as it is only used by explicit-naming contingency list.
No description provided.