Implement custom report tree for report viewer #2416
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 677 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 633 | 2 | 42 | 0 |
Click to see the invalid file list
- src/components/custom-treeview/TreeViewItem.tsx
- src/components/custom-treeview/VirtualizedTreeView.tsx
There was a problem hiding this comment.
license-eye has totally checked 685 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 640 | 1 | 44 | 0 |
Click to see the invalid file list
- src/components/custom-treeview/use-treeview-scroll.ts
Meklo
changed the title
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
force-pushed
the
feat/custom-report-tree
branch
from
96bfff7 to
227b2ae
Compare
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
…-virtualized library instead of react-virtualized-auto-sizer for homogeneity purpose
Meklo
changed the title
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
| </ReportItem> | ||
| ); | ||
| const mapReportsById = useCallback((item: ReportTree) => { | ||
| reportTreeMap.current[item.id] = item; |
There was a problem hiding this comment.
should maybe throw away the old map and assign a new empty object to reportTreeMap.current ?
| setSelectedReportType(reportTreeMap.current[report.id].type); | ||
| } | ||
| }, | ||
| [selectedReportId] |
There was a problem hiding this comment.
maybe in a separate PR we can try to refactor this code a bit. I find it weird for example that we go to the extend of using a ref for the map of ids to reports to avoid having it in the dependencies of this callback, but at the same time it has selectedReportId in its dependencies which presumably changes more often than the reportTree (and maybe even always changes when the reporttree is changed?).
Another weird thing is top use useCallback for callbacks for VirtualizedTreeview, but not for callbacks for LogTable (onLogRowClick is not a useCallback).. To be cleaned up later I guess
|
No description provided.