Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements suggestions from comments by @jonenst in #2416 and additional improvements, here's a rundown :
selectedReportId
andselectedReportType
under a single state since they are tightly coupledreportTreeMap
content before recomputing it to avoid possible incoherent stateselectedReportId
from callback dependency array by instead comparing it by its previous statereport
which is required to instanciate report-viewerparentId
value inonLogRowClick
to avoid arbitrary string cast when value is possibly nulluseDispatch
declaration which was unused